Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added showAll option for the Search page as a tri-state checkbox #164

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

HeidiTao
Copy link
Contributor

@HeidiTao HeidiTao commented Oct 6, 2024

Description

Added showAll option for the Search page as a tri-state checkbox, based on the show settings of FCEs, Course Info, and Schedules.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Trying out different combinations of show selections for FCEs, Course Info, and Schedules, for both logged-in users and guests.

Test Configuration:

  • Node.js version: v20.16.0
  • Desktop/Mobile: Desktop
  • OS: Windows
  • Browser: Chrome

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

railway-app bot commented Oct 6, 2024

This PR was not deployed automatically as @HeidiTao does not have access to the Railway project.

In order to get automatic PR deploys, please add @HeidiTao to your team on Railway.

@HeidiTao HeidiTao requested a review from Xavilien October 6, 2024 01:18
Copy link
Member

@Xavilien Xavilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some styling, otherwise looks good!

@Xavilien Xavilien merged commit cca5d76 into main Oct 6, 2024
1 check failed
@Xavilien Xavilien deleted the heidit/search-showAll branch October 6, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants