Added GovernorVotesCompQuorumFraction for settable quorum #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
jferas
force-pushed
the
update-readme
branch
from
c9e24c7
to
2e6cb9e
Compare
jferas
force-pushed
the
settable-quorum
branch
from
1fbf1f2
to
741c4ea
Compare
jferas
changed the title
jferas
force-pushed
the
settable-quorum
branch
from
ff62acd
to
741c4ea
Compare
jferas
changed the title
jferas
changed the title
alexkeating
reviewed
Nov 21, 2023
jferas
force-pushed
the
update-readme
branch
from
2e6cb9e
to
252d828
Compare
jferas
force-pushed
the
settable-quorum
branch
from
741c4ea
to
ee6f28a
Compare
jferas
force-pushed
the
update-readme
branch
from
252d828
to
50458d4
Compare
jferas
force-pushed
the
settable-quorum
branch
from
ee6f28a
to
56e85e0
Compare
jferas
force-pushed
the
update-readme
branch
from
50458d4
to
212a699
Compare
jferas
force-pushed
the
settable-quorum
branch
from
56e85e0
to
021894e
Compare
jferas
force-pushed
the
update-readme
branch
from
1aaa4b1
to
1deaf32
Compare
jferas
force-pushed
the
settable-quorum
branch
from
021894e
to
265fcc1
Compare
jferas
force-pushed
the
settable-quorum
branch
from
265fcc1
to
5b37a39
Compare
jferas
force-pushed
the
settable-quorum
branch
from
5b37a39
to
f4ac9a3
Compare
jferas
force-pushed
the
settable-quorum
branch
from
f4ac9a3
to
b83b9c3
Compare
jferas
force-pushed
the
settable-quorum
branch
from
b83b9c3
to
9500352
Compare
This was referenced Dec 8, 2023
alexkeating
reviewed
Dec 13, 2023
| @@ -0,0 +1,125 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // (Based on OpenZeppelin governance/extensions/GovernorVotesQuorumFraction.sol) | |||
There was a problem hiding this comment.
It would probably be better to use a permalink to the OpenZeppelin contract
| function _updateQuorumNumerator(uint256 newQuorumNumerator) internal virtual { | ||
| require( | ||
| newQuorumNumerator <= quorumDenominator(), | ||
| "GovernorVotesQuorumFraction: quorumNumerator over quorumDenominator" |
There was a problem hiding this comment.
Does this need to say "GovernorVotesQuorumCompFraction"?
| * quorum | ||
| * expressed as a fraction of the total supply. | ||
| */ | ||
| abstract contract GovernorVotesCompQuorumFraction is GovernorVotesComp { |
There was a problem hiding this comment.
Although obvious it may be good to explicitly say this line has changed from the original.
|
Radworks has chosen to go with a fixed, constant quorum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GovernorVotesCompQuorumFraction for settable quorum
Also added test for setting quorum numerator