ci(slither): add config file #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: add slither * ci: slither code scanning integration * ci: change configs * build: bump pragma * build: change pragmas
* docs: add WIP note * ci: add scopelint to ci * fix: add foundry install step to CI * style: move fmt before slither so both slither tasks are adjacent in PRs * wrong solidity formatting to test ci fmt job * fix solidity and break toml formatting to test fmt ci job * restore formatting
* one test should error * chore: fix naming convention + exclude that slither check
* add unused function to fail slither and update ci * dummy commit * add comment * updates
* chore: put ci profile first since it inherits default solc, fix typo * docs: update README * build: update forge-std * ci: download scopelint binary * ci: fix repo * ci: try different binary * docs: update README
* ci: remove 'install deps' step, foundry does this automatically * ci: initial coverage check * chore: install deps for coverage (not yet auto installed) * ci: install lcov * ci: forgot to generate lcov * ci: comment out the lcov directory filter * ci: filter out test and script dirs by default * refactor: use deploy script to scaffold tests, follow best practice test structure + naming conventions * docs: update docs * docs: add info on coverage * ci: forge coverage now installs missing deps * ci: log scopelint version * ci: remove outdated rust toolchain install * chore: comment out broadcast call in sample script for now * chore: add lcov.info to gitignore * ci: preserve coverage branch info * docs: update best practices link and coverage section * ci: also print coverage summary in CI (though it won't be filtered) * doc: add comments
* ci: add second coverage tool * try another * maybe remove versioning fixes other tool * fixes * test comment deletion * test title * remove title * test * always run * restore normal counter file * cleanup ci file
docs: update note about caching
* ci: fix bug in "slither-analyze" job in ci.yml * ci: change the target from "contracts/" to "src/" * ci: add "security-events" write permission to "slither-analyze" job in ci.yml * ci: remove redundant "filter-paths" arg from "slither-analyze" job
* ide gitignore * style: capitalization --------- Co-authored-by: Matt Solomon <[email protected]>
* chore: disable slither reentrancy detector in scripts * build: pin to 0.8.20 * chore: absolute imports * ci: ignore solc-version check this check is subjective, and I don't think project should necessarily follow the version recommendations from slither (partly because historically the versions suggested by that check were not updated frequently) * build: explicitly specify evm version to protect against foundry changing the default * docs: update README
mds1
reviewed
Sep 21, 2023
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "detectors_to_exclude": "naming-convention,solc-version", | |||
| "filter_paths": "(./lib|./test)" | |||
There was a problem hiding this comment.
Are the parentheses needed here? Since before when passed directly to the CLI it was "./lib|./test" without the parentheses
There was a problem hiding this comment.
From my local testing it seems they are not needed
Suggested change
| "filter_paths": "(./lib|./test)" | |
| "filter_paths": "./lib|./test" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21