chore: fixes and improvements #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mds1
commented
Jul 27, 2023
mds1
commented
- Fixes bugs around handing interfaces and metadata hashes
- New integration test handles this, though it will currently fail in CI due to bug: regression introduced in PR#5397 (remapping contexts) foundry-rs/foundry#5475
- Seaport test now fails because the found vs. expected leading bytecode differs. This did not used to be the case, so it's skipped for now and will be resolved later
|
We deploy on merge to main, but some repos are currently broken due to foundry-rs/foundry#5475. It should be fixed soon, so holding off on merge for a bit so we can verify things look good before merging |
|
CI now passing thanks to foundry-rs/foundry#5532, so merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.