Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Enumerable proposal ids #33

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

jferas
Copy link
Collaborator

@jferas jferas commented Oct 16, 2024

resolves #9

@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11483405126

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 55 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-8.1%) to 79.193%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/CompoundGovernor.sol 0 11 0.0%
contracts/extensions/GovernorStorageEnumIdsUpgradeable.sol 0 44 0.0%
Files with Coverage Reduction New Missed Lines %
contracts/CompoundGovernor.sol 1 0.0%
Totals Coverage Status
Change from base Build 11461628746: -8.1%
Covered Lines: 318
Relevant Lines: 416

💛 - Coveralls

@jferas jferas changed the base branch from main to settable-fixed-quorum-test October 16, 2024 18:32
@jferas jferas marked this pull request as ready for review October 18, 2024 19:21
@jferas jferas changed the base branch from settable-fixed-quorum-test to main October 21, 2024 15:23
@jferas jferas marked this pull request as draft October 21, 2024 17:38
@jferas jferas marked this pull request as ready for review October 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Make proposalIds enumerable
2 participants