Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Make proposalIds enumerable #9

Open
wildmolasses opened this issue Sep 24, 2024 · 0 comments · May be fixed by #33
Open

Feat: Make proposalIds enumerable #9

wildmolasses opened this issue Sep 24, 2024 · 0 comments · May be fixed by #33
Assignees

Comments

@wildmolasses
Copy link
Collaborator

wildmolasses commented Sep 24, 2024

Enumerable Proposal IDs: Unlike out of the box OZ governors, where proposalIds are calculated from hashing the contents of a proposal, we will keep the incrementing proposalId pattern of Governor Bravo. To implement this, we will use the GovernorStorage extension with some modifications to incorporate enumerability of proposalIds.

The proposalID numbers should pick up from the last GovernorBravo proposalID

@wildmolasses wildmolasses changed the title Make proposalIds enumerable Feat: Make proposalIds enumerable Sep 24, 2024
@jferas jferas self-assigned this Oct 8, 2024
@jferas jferas linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants