Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a setup.py, auto-detect subdir/arch, allow insecure server (for debug, or easy proxy behind nginx), update README #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added a setup.py, auto-detect subdir/arch, allow insecure server (for debug, or easy proxy behind nginx), update README #5

wants to merge 3 commits into from

Conversation

pelson
Copy link
Contributor

@pelson pelson commented May 2, 2018 •
edited
Loading

Sorry it is a bit of a mammoth PR - there were a few changes that enabled others, and it was quite hard to separate.

In this PR

  • make the thing installable with a setup.py
  • make it possible to run an unsecured server (useful for nginx proxy, and delegating auth elsewhere)
  • auto-detect the arch/subdir, rather than allowing the client to tell you where it should go (cc @bjlittle)
  • split off the token authentication into its own module, and provide a CLI to allow users to get the tokens easily
  • update the README to provide details on how to run a basic server
  • update the README to provide details on how to create authentication tokens

@pelson pelson requested a review from DPeterK May 2, 2018 09:22
@pelson
Updated code to automatically detect the architecture of the binary.
ea491a9 
Allowed the server to run without authentication and SSL (in case somebody wants to do that with nginx, for example).
@pelson pelson changed the title Added a setup.py, and handled the fallout. Added a setup.py, auto-detect subdir/arch, allow insecure server (for debug, or easy proxy behind nginx), update README May 2, 2018
@pelson
Copy link
Contributor Author

pelson commented May 18, 2018

Ping @bjlittle. Would be good to bank this - will make future dev much easier.

@bjlittle bjlittle self-assigned this May 27, 2018
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DPeterK DPeterK Awaiting requested review from DPeterK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pelson @CLAassistant @bjlittle