Fix unit tests for invalid config (#867)

SatelliteQE · Jan 4, 2023 · bd34895 · bd34895
1 parent 10cb199
commit bd34895
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/tests/test_config.py b/tests/test_config.py
@@ -6,6 +6,7 @@
 from unittest.mock import mock_open
 from unittest.mock import patch
 
+from packaging.version import InvalidVersion
 from packaging.version import parse
 
 from nailgun.config import _get_config_file_path
@@ -19,8 +20,8 @@
  'default': {'url': 'http://example.com'},
  'Ask Aak': {'url': 'bogus value', 'auth': ['username', 'password']},
  'Acros-Krik': {'url': 'booger', 'version': '1.2.3.4.dev5+67'},
- 'King Adas': {'url': 'burger', 'version': 'silly version'},
 }
+INVALID_CONFIG = {'url': 'burger', 'version': 'silly version'}
 CONFIGS2 = CONFIGS.copy()
 CONFIGS2.update(
  {
@@ -62,6 +63,13 @@ def test_init(self):
  vars(BaseServerConfig(**config)),
  )
 
+ def test_init_invalid(self):
+ """Test instantiating :class: `nailgun.config.BaseServerConfig`.
+ Assert that configs with invalid versions do not load.
+ """
+ with self.assertRaises(InvalidVersion):
+ _convert_bsc_attrs(INVALID_CONFIG)
+
  def test_get(self):
  """Test :meth:`nailgun.config.BaseServerConfig.get`.