SWC-7102 #5551
SWC-7102 #5551
Conversation
| @@ -14,8 +14,6 @@ public interface SynapseJSNIUtils { | |||
|
|
|||
| public void highlightCodeBlocks(); | |||
|
|
|||
| void loadSummaryDetailsShim(); | |||
| @@ -61,14 +61,18 @@ protected void onLoad() { | |||
|
|
|||
| @Override | |||
| protected void onUnload() { | |||
There was a problem hiding this comment.
I think the scenario triggering the bug in SWC-7102 is that a ReactComponent widget is unloaded and then re-loaded almost immediately. Since this.root from the first load, which cannot be reused after unmount is called, is still present when the second load happens, React throws an error.
We unmount the root asynchronously because because the call to onUnload may have been triggered within React's render cycle, which is also not allowed. Putting the unmount call in a Timer schedules it in the task queue, which will run after React finishes rendering (which happens in the microtask queue).
To fix this, we can synchronously clear the widget's this.root field, while still deferring the call to unmount.
| @@ -94,8 +94,17 @@ private void createRoot() { | |||
|
|
|||
| private void destroyRoot() { | |||
There was a problem hiding this comment.
Add the same logic to ReactComponentV2.
| oldRoot.unmount(); | ||
| } | ||
| }; | ||
| t.schedule(0); |
There was a problem hiding this comment.
Move the timer logic to the helper method
No description provided.