Rename ssh_minion for sshminion and change nodeHandler behavior. #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace by sshminion Update nodeHandler to manager this change.
ktsamis
approved these changes
Sep 16, 2024
|
Replace by #1364 to avoid conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After discussion about the minion renaming, we decided to see sshminion as one word without seperation.
Solution
Rename modules names and references to change ssh_minion to sshminion.
Update the minion list to use sshminion.
Update nodeHandler to not convert sshminion into ssh_minion.
Specific 5.0 BV NUE changes
Move the changes from #1310 into this PR to avoid conflicts
Tests
Changes tested during https://ci.suse.de/blue/organizations/jenkins/manager-4.3-qe-build-validation-NUE/detail/manager-4.3-qe-build-validation-NUE/355/pipeline