-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCTEAM-1114 - SMART DOCS - Modifying kernel boot parameters #210
base: main
Are you sure you want to change the base?
DOCTEAM-1114 - SMART DOCS - Modifying kernel boot parameters #210
Conversation
66f768d
to
6ea81b8
Compare
809d8b7
to
ea55420
Compare
8d2ada6
to
ab40e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, a very good first attempt. I think what is still missing, is some explanation when fiddling with Kernel parameters is need/wanted (e.g. tuning? troubleshooting, energy saving, etc). For this you should speak to SMEs.
And before this gets published, it needs to be turned into topics and an assembly,
Thanks Souvik!
<screen>setparams '&productname; &productnumber;' | ||
<procedure> | ||
<para> | ||
To temporarily disable the splash screen, proceed as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear that this is just an example. I would move this into the previous paragrtaph saying: In the following example, the splash screen is temporarily disabled.
Maybe you also shopuld add and modify a parameter with this example to cover the three most common use-cases.
Also, some general rules should be mentioned, such as that parameters are separated by space. And (if applicable, not sure) how to correctly quote or escape if a value contains a space. Maybe even move this into a general introduction, because it applies to both, temporarily and permanently modifying parameters.
7ddefed
to
213a418
Compare
3e043c3
to
47d23b5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
9217dd7
to
3ff519b
Compare
30183f9
to
f52c088
Compare
1c5d5f3
to
5fbf5a6
Compare
47c85f2
to
569c217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for overhauling and very well done! I know the editorial review is still to follow after the content review. Nevertheless, I included some code suggestions for typos or other small things that I spotted during the content review. More feedback to come via mail - many thanks!
567ee30
to
c99045f
Compare
523f9f6
to
d16acbe
Compare
d16acbe
to
e512796
Compare
0bb5b0f
to
44647bf
Compare
intermediate changes intermediate changes draft content complete Solved build problem by changing root element from topic to article Fixed typo trivial changes Fixes based on review comments Splitting DC file into two for profiling using PROFOS intermediate changes total revamp of core content restructuring in progress Intermediate changes in assembly structure rearrangements temporary and permanent procedure modularization linuxrc difference partial modularization complete modularization; attempting solution of build errors build problem solved removed the generic profiling dc file
44647bf
to
6dc5f00
Compare
Description
Smart docs on the topic "Modifying kernel boot parameters"
Are there any relevant issues/feature requests?
Is this (based on) existing content?