Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR090a: Harmonization of ActionStatus and Progress in SX #100

Open
wants to merge 5 commits into
base: integration
Choose a base branch
from

Conversation

haeckerbaer
Copy link
Collaborator

@haeckerbaer haeckerbaer added the enhancement New feature or request label Oct 25, 2022
@haeckerbaer haeckerbaer added this to the v2.2 milestone Oct 25, 2022
@haeckerbaer haeckerbaer self-assigned this Oct 25, 2022
prirey
prirey previously approved these changes Oct 26, 2022
Copy link
Collaborator

@prirey prirey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Aurige
Aurige previously approved these changes Oct 26, 2022
tim-rivett
tim-rivett previously approved these changes Oct 26, 2022
@gthiesing
Copy link

It seems to me there is a misunderstanding of SIRI processes underliying.
In SIRI there is a Situation Progress State (refer to 5.3.6.3) which refers to the status of the situation itself and this status comprises the status 'closing' already descibing that the situation itself is in process of getting regular (refer to annex E.3.2). If as the example shows it getting only partly to regular operation SIRI requests an update of the situation with exactly this information.
The status element of the publishing action reports the status of publishing not of the situation itself therefore 'closing' is meaningless since the information about a situation can only be prepared (open), can be published (published) or can be deleted (closed)

@Aurige
Copy link
Contributor

Aurige commented Feb 27, 2023

You are right @gthiesing , we shall not mix Situation Progress State and Publishing Action Status. However, my understanding from @haeckerbaer proposal is to add a real Publishing Action Status, dedicated to the communication to passenger (see https://3.basecamp.com/3256016/buckets/9672657/messages/5836829085 - Public is informed about ongoing normalisation) and related to the specific Publishing Action (not to all consequences of the Situation).
So the documentation and XSD comment must state this very clearly.
I still agree with the proposal on my side (in fact I found the same use case in France ...)

@haeckerbaer haeckerbaer changed the title CR090: Harmonization of ActionStatus and Progress in SX CR090a: Harmonization of ActionStatus and Progress in SX Aug 24, 2023
@haeckerbaer
Copy link
Collaborator Author

haeckerbaer commented Mar 20, 2024

update incoming as discussed in the basecamp: A boolean SituationIsClosing is introduced on PtSituationElement level that corresponds to ActionIsClosing. We should not correlate the closing value of ProgressEnum with a boolean.

Copy link
Collaborator

@prirey prirey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls separate the interpretation of Progress and ActionIsClosing.
Progress is not required for showing the "Closing icon"

xsd/siri_model/siri_situationActions.xsd Outdated Show resolved Hide resolved
@haeckerbaer haeckerbaer requested a review from prirey June 14, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants