Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customLabels to ServiceInstance and ServiceBinding #454

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kaedwen
Copy link

@kaedwen kaedwen commented Jul 11, 2024

Pull Request Template

Prerequisites

fixes #453

Motivation

We are using the btp-service-operator in our environment and we need to create hana-shared aka. hana tenants. During this to also be consumable via CAP there must be a label for tenant_id and service_plan_id because CAP searches for it.

To be able to provide that from a kubernetes environment the solution would be to allow adding custom labels to the CRD's.

Approach

With that PR the CRD's have an additional customLabels field where labels can be added to the instance/binding

Pull Request status

  • Initial implementation
  • Refactoring
  • Unit tests
  • Integration tests

Third-party code

none

@kaedwen kaedwen changed the title [WIP] add customLabels to ServiceInstance and ServiceBinding Add customLabels to ServiceInstance and ServiceBinding Jul 11, 2024
@github-actions github-actions bot added the Stale label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom labels handling to instance and binding
2 participants