-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): address Avatar Group issues #12530
base: main
Are you sure you want to change the base?
Conversation
- Fixed focus on avatar group
…hancements Closes [#12369](#12369) ## Description - Fixed focus bug where focus remained on the first avatar group control after interacting with the second one. - Fixed rendering issue where only "+n more" button displayed after switching tabs instead of the full avatar group row. - Added feature to open group popover from the center of the avatar group. - Added configuration option to make "+n more" button circular to match avatars typically being in circle shapes. - Introduced property to set the number of visible avatars before displaying the "+n more" button.
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit the preview URL for this PR (updated for commit f587f50): https://fundamental-ngx-gh--pr12530-fix-core-avatar-gro-krwggyds.web.app (expires Fri, 18 Oct 2024 09:00:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
<fd-avatar-group-default-example></fd-avatar-group-default-example> | ||
</component-example> | ||
<code-example [exampleFiles]="avatarGroupDefaultExample"></code-example> | ||
<!--<fd-docs-section-title id="default" componentName="AvatarGroup"> Avatar Group Standard Usage </fd-docs-section-title>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not ready yet for review. I converted this PR as a draft. @mikerodonnell89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but what is going on with all of the commented out html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the "group type standard usage" examples, after opening the popover, i can not navigate through the avatars with the arrow keys or tab key. Because each avatar in the popover is clickable, we do need this functionality with keyboard control as well
@mikerodonnell89 In this example, the web components avatar group features tab navigation but lacks arrow navigation. I'm currently working on implementing tab navigation. |
fix(core): Resolve focus retention & rendering issues, add feature enhancements
Closes #12369
Description