Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): form label required * should be aria-hidden #12523

Closed
wants to merge 1 commit into from

Conversation

mikerodonnell89
Copy link
Member

fixes #11284

@mikerodonnell89 mikerodonnell89 requested a review from a team October 7, 2024 19:18
@mikerodonnell89 mikerodonnell89 self-assigned this Oct 7, 2024
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 23b2b89
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6704340389462f0008b16338
😎 Deploy Preview https://deploy-preview-12523--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 7, 2024

Visit the preview URL for this PR (updated for commit 23b2b89):

https://fundamental-ngx-gh--pr12523-fix-11284-6rju61p9.web.app

(expires Thu, 10 Oct 2024 19:22:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-08 at 10 22 47 AM

Have you tested the output with SR? aria-hidden will remove the content and the children from the a11y tree and the label shouldn't be read.

@InnaAtanasova
Copy link
Contributor

InnaAtanasova commented Oct 8, 2024

Screenshot 2024-10-08 at 10 22 47 AM Have you tested the output with SR? `aria-hidden` will remove the content and the children from the a11y tree and the label shouldn't be read.

Maybe check this article with options to hide the pseudo element from SR: https://stackoverflow.com/questions/46815260/hide-a-pseudo-element-from-a-screenreader

Also this: https://dev.to/whitep4nth3r/hide-text-in-css-pseudo-elements-from-screen-readers-with-this-one-weird-trick-11eg

https://www.sitelint.com/blog/hide-content-in-css-pseudo-elements-from-screen-readers

@mikerodonnell89
Copy link
Member Author

Closing, fix will come in styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sourcing-2][Accessibility: ACC-264.1] Required information read as star.
2 participants