-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): toolbar render spacer before overflow conditionally #12453
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit the preview URL for this PR (updated for commit b151598): https://fundamental-ngx-gh--pr12453-fix-toolbar-spacer-bbhxy52c.web.app (expires Fri, 11 Oct 2024 00:07:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
84ff810
to
d0d28cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as the issue I pointed out was pre-existing, but not apparent in the example due to the example previously not having the spacer. We can address that in another issue
c0e010d
to
30bbfac
Compare
7274a94
to
68dafb5
Compare
68dafb5
to
b151598
Compare
Related Issue(s)
closes #12239
Description
render spacer before the overflow button conditionally (only if the application doesn't have non-fixed spacer)