Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): segmented button accessibility improvements #11054

Closed
wants to merge 2 commits into from

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Dec 5, 2023

fixes #10805

a clean PR for #10932

@droshev droshev self-assigned this Dec 5, 2023
@droshev droshev added this to the Sprint 127 milestone Dec 5, 2023
@droshev droshev added the ng15 Angular 15 support label Dec 5, 2023
Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 98ecd39
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/657349d7bd7f0a0008cf51c5
😎 Deploy Preview https://deploy-preview-11054--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 5, 2023

Visit the preview URL for this PR (updated for commit 3aa6826):

https://fundamental-ngx-gh--pr11054-fix-segmented-button-pmvjkwck.web.app

(expires Sat, 09 Dec 2023 16:02:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@g-cheishvili
Copy link
Contributor

No example updates?

@InnaAtanasova
Copy link
Contributor


<ul 
    role="listbox" 
    aria-multiselectable="false" 
    aria-orientation="horizontal"
    aria-roledescription="Segmented button group" 
    aria-describedby="..." 
    class="..." 
    tabindex="-1">
    <li 
      tabindex="-1" 
      role="option"
      aria-roledescription="Segmented button" 
      aria-posinset="1" 
      aria-setsize="3" 
      aria-selected="false"
      class="..." 
      style="...">
    ...
    </li>
    <li 
      tabindex="0" 
      role="option"
      aria-roledescription="Segmented button" 
      aria-posinset="2" 
      aria-setsize="3" 
      aria-selected="true"
      class="..." 
      style="...">
      ...
    </li>
    <li 
      tabindex="-1" 
      role="option"
      aria-roledescription="Segmented button" 
      aria-posinset="3" 
      aria-setsize="3" 
      aria-selected="false"
      class="..." 
      style="...">
      ...
    </li>
  </ul>

@InnaAtanasova
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ng15 Angular 15 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants