fix(core): prevent potential for infinite loop when two file uploader…

…s have the same ngModel
SAP · Oct 24, 2024 · c7bf8a7 · c7bf8a7
1 parent ad20842
commit c7bf8a7
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/libs/core/file-uploader/file-uploader.component.ts b/libs/core/file-uploader/file-uploader.component.ts
@@ -195,12 +195,12 @@ export class FileUploaderComponent implements ControlValueAccessor, OnDestroy, F
 
     /** @hidden */
     writeValue(files: File[]): void {
-        if (files && files.length === 0) {
+        if (this.validFiles.length > 0 && files && files.length === 0) {
             this.clear();
         } else if (this._isEmpty()) {
             return;
         } else {
-            this._propagateFiles();
+            this._propagateFiles(false);
         }
     }
 
@@ -288,9 +288,11 @@ export class FileUploaderComponent implements ControlValueAccessor, OnDestroy, F
     }
 
     /** @hidden */
-    private _propagateFiles(): void {
+    private _propagateFiles(handleOnChange: boolean = true): void {
         this.setInputValue(this.validFiles);
-        this.onChange(this.validFiles);
+        if (handleOnChange) {
+            this.onChange(this.validFiles);
+        }
         this.selectedFilesChanged.emit(this.validFiles);
         this.selectedInvalidFiles.emit(this.invalidFiles);
     }