Merge branch 'main' into fix(core)/default-height-missing

SAP · Oct 10, 2024 · 3b1a074 · 3b1a074
2 parents 83dc7d9 + 4783dce
commit 3b1a074
Show file tree

Hide file tree

Showing 37 changed files with 573 additions and 65 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,50 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.7](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.6...v0.53.1-rc.7) (2024-10-08)
+
+
+### Bug Fixes
+
+* **core:** translations for Notification component ([#12524](https://github.com/SAP/fundamental-ngx/issues/12524)) ([cd8df83](https://github.com/SAP/fundamental-ngx/commit/cd8df832c53cef6d77bfee8cd232e0af52251407))
+
+
+
+
+
+## [0.53.1-rc.6](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.5...v0.53.1-rc.6) (2024-10-08)
+
+
+### Bug Fixes
+
+* **core:** remove redundant api calls in dynamic page ([#12504](https://github.com/SAP/fundamental-ngx/issues/12504)) ([d3aaa89](https://github.com/SAP/fundamental-ngx/commit/d3aaa895caa7ffb1bb0360e4576013e8c2adf0c2))
+
+
+
+
+
+## [0.53.1-rc.5](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.4...v0.53.1-rc.5) (2024-10-08)
+
+
+### Bug Fixes
+
+* **core,platform:** radio a11y improvements ([#12525](https://github.com/SAP/fundamental-ngx/issues/12525)) ([350b09a](https://github.com/SAP/fundamental-ngx/commit/350b09a6af867fd7c87d09132e56cde340a957a4))
+
+
+
+
+
+## [0.53.1-rc.4](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.3...v0.53.1-rc.4) (2024-10-08)
+
+
+### Bug Fixes
+
+* **core:** stop month/year cell to change size on date picker month/year range selection ([#12526](https://github.com/SAP/fundamental-ngx/issues/12526)) ([29bfe7d](https://github.com/SAP/fundamental-ngx/commit/29bfe7db5d1eebf487067c5155759ec638068f52)), closes [#12522](https://github.com/SAP/fundamental-ngx/issues/12522)
+
+
+
+
+
 ## [0.53.1-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.2...v0.53.1-rc.3) (2024-10-08)
 
 

diff --git a/lerna.json b/lerna.json
@@ -1,7 +1,7 @@
 {
     "$schema": "node_modules/lerna/schemas/lerna-schema.json",
     "packages": ["libs/*"],
-    "version": "0.53.1-rc.3",
+    "version": "0.53.1-rc.7",
     "conventionalCommits": true,
     "tagVersionPrefix": "v",
     "message": "chore(release): publish %v",

diff --git a/libs/btp/CHANGELOG.md b/libs/btp/CHANGELOG.md
@@ -3,6 +3,38 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.7](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.6...v0.53.1-rc.7) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/btp
+
+
+
+
+
+## [0.53.1-rc.6](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.5...v0.53.1-rc.6) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/btp
+
+
+
+
+
+## [0.53.1-rc.5](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.4...v0.53.1-rc.5) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/btp
+
+
+
+
+
+## [0.53.1-rc.4](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.3...v0.53.1-rc.4) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/btp
+
+
+
+
+
 ## [0.53.1-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.2...v0.53.1-rc.3) (2024-10-08)
 
 **Note:** Version bump only for package @fundamental-ngx/btp

diff --git a/libs/btp/package.json b/libs/btp/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@fundamental-ngx/btp",
-    "version": "0.53.1-rc.3",
+    "version": "0.53.1-rc.7",
     "peerDependencies": {
         "@angular/common": "ANGULAR_VER_PLACEHOLDER",
         "@angular/core": "ANGULAR_VER_PLACEHOLDER",

diff --git a/libs/cdk/CHANGELOG.md b/libs/cdk/CHANGELOG.md
@@ -3,6 +3,38 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.7](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.6...v0.53.1-rc.7) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/cdk
+
+
+
+
+
+## [0.53.1-rc.6](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.5...v0.53.1-rc.6) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/cdk
+
+
+
+
+
+## [0.53.1-rc.5](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.4...v0.53.1-rc.5) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/cdk
+
+
+
+
+
+## [0.53.1-rc.4](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.3...v0.53.1-rc.4) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/cdk
+
+
+
+
+
 ## [0.53.1-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.2...v0.53.1-rc.3) (2024-10-08)
 
 **Note:** Version bump only for package @fundamental-ngx/cdk

diff --git a/libs/cdk/package.json b/libs/cdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@fundamental-ngx/cdk",
-  "version": "0.53.1-rc.3",
+  "version": "0.53.1-rc.7",
   "schematics": "./schematics/collection.json",
   "description": "Fundamental Library for Angular - CDK",
   "license": "Apache-2.0",

diff --git a/libs/core/CHANGELOG.md b/libs/core/CHANGELOG.md
@@ -3,6 +3,47 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.7](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.6...v0.53.1-rc.7) (2024-10-08)
+
+
+### Bug Fixes
+
+* **core:** translations for Notification component ([#12524](https://github.com/SAP/fundamental-ngx/issues/12524)) ([cd8df83](https://github.com/SAP/fundamental-ngx/commit/cd8df832c53cef6d77bfee8cd232e0af52251407))
+
+
+
+
+
+## [0.53.1-rc.6](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.5...v0.53.1-rc.6) (2024-10-08)
+
+
+### Bug Fixes
+
+* **core:** remove redundant api calls in dynamic page ([#12504](https://github.com/SAP/fundamental-ngx/issues/12504)) ([d3aaa89](https://github.com/SAP/fundamental-ngx/commit/d3aaa895caa7ffb1bb0360e4576013e8c2adf0c2))
+
+
+
+
+
+## [0.53.1-rc.5](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.4...v0.53.1-rc.5) (2024-10-08)
+
+**Note:** Version bump only for package @fundamental-ngx/core
+
+
+
+
+
+## [0.53.1-rc.4](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.3...v0.53.1-rc.4) (2024-10-08)
+
+
+### Bug Fixes
+
+* **core:** stop month/year cell to change size on date picker month/year range selection ([#12526](https://github.com/SAP/fundamental-ngx/issues/12526)) ([29bfe7d](https://github.com/SAP/fundamental-ngx/commit/29bfe7db5d1eebf487067c5155759ec638068f52)), closes [#12522](https://github.com/SAP/fundamental-ngx/issues/12522)
+
+
+
+
+
 ## [0.53.1-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.2...v0.53.1-rc.3) (2024-10-08)
 
 

diff --git a/libs/core/calendar/calendar-views/calendar-month-view/calendar-month-view.component.html b/libs/core/calendar/calendar-views/calendar-month-view/calendar-month-view.component.html
@@ -10,14 +10,6 @@
                     <td
                         class="fd-calendar__my-item"
                         role="gridcell"
-                        [class.fd-calendar__item--selected]="
-                            monthCell.selectedFirst || monthCell.selectedLast || monthCell.selected
-                        "
-                        [class.fd-calendar__item--range]="
-                            (monthCell.selectedRange || monthCell.hoverRange) &&
-                            !monthCell.selectedFirst &&
-                            !monthCell.selectedLast
-                        "
                         [class.fd-calendar__my-item--current]="monthCell.current"
                         [class.is-active]="monthCell.selected"
                         [attr.tabIndex]="monthCell.tabIndex"
@@ -32,6 +24,12 @@
                         <button
                             fd-button
                             fdType="transparent"
+                            [class.fd-button--toggled]="
+                                monthCell.selectedRange ||
+                                monthCell.hoverRange ||
+                                monthCell.selectedFirst ||
+                                monthCell.selectedLast
+                            "
                             class="fd-calendar__my-item-button"
                             [class.is-active]="monthCell.current"
                             tabindex="-1"

diff --git a/libs/core/calendar/calendar-views/calendar-year-view/calendar-year-view.component.html b/libs/core/calendar/calendar-views/calendar-year-view/calendar-year-view.component.html
@@ -10,14 +10,6 @@
                     <td
                         class="fd-calendar__my-item"
                         role="gridcell"
-                        [class.fd-calendar__item--range]="
-                            (yearCell.selectedRange || yearCell.hoverRange) &&
-                            !yearCell.selectedFirst &&
-                            !yearCell.selectedLast
-                        "
-                        [class.fd-calendar__item--selected]="
-                            yearCell.selectedFirst || yearCell.selectedLast || yearCell.selected
-                        "
                         [class.fd-calendar__my-item--current]="yearCell.current"
                         [class.is-active]="yearCell.selected"
                         [attr.id]="yearCell.id"
@@ -32,6 +24,12 @@
                         <button
                             fd-button
                             fdType="transparent"
+                            [class.fd-button--toggled]="
+                                yearCell.selectedRange ||
+                                yearCell.hoverRange ||
+                                yearCell.selectedFirst ||
+                                yearCell.selectedLast
+                            "
                             class="fd-calendar__my-item-button"
                             [class.is-active]="yearCell.current"
                             tabindex="-1"

diff --git a/libs/core/notification/notification-group-header/notification-group-header.component.ts b/libs/core/notification/notification-group-header/notification-group-header.component.ts
@@ -3,16 +3,18 @@ import {
     ChangeDetectionStrategy,
     Component,
     HostListener,
+    OnInit,
     ViewEncapsulation,
     computed,
     inject,
-    input,
     signal
 } from '@angular/core';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { KeyUtil, Nullable, RtlService } from '@fundamental-ngx/cdk/utils';
 import { ButtonComponent } from '@fundamental-ngx/core/button';
 import { ContentDensityDirective } from '@fundamental-ngx/core/content-density';
 import { IconComponent } from '@fundamental-ngx/core/icon';
+import { FD_LANGUAGE, FdLanguage, TranslationResolver } from '@fundamental-ngx/i18n';
 import { NotificationGroupBaseDirective } from '../notification-utils/notification-group-base';
 import { FD_NOTIFICATION_GROUP_HEADER } from '../token';
 
@@ -45,12 +47,12 @@ import { FD_NOTIFICATION_GROUP_HEADER } from '../token';
         }
     ]
 })
-export class NotificationGroupHeaderComponent extends NotificationGroupBaseDirective {
+export class NotificationGroupHeaderComponent extends NotificationGroupBaseDirective implements OnInit {
     /**
      * Title for the group header
      * default value: "Expand/Collapse"
      */
-    title = input('Expand/Collapse');
+    title = signal<Nullable<string>>('');
 
     /**
      * id of the list element that the group header controls
@@ -69,6 +71,12 @@ export class NotificationGroupHeaderComponent extends NotificationGroupBaseDirec
     /** @hidden */
     private readonly _rtlService = inject(RtlService, { optional: true });
 
+    /** @hidden */
+    private readonly _lang$ = inject(FD_LANGUAGE);
+
+    /** @hidden */
+    private _translationResolver = new TranslationResolver();
+
     /** @hidden */
     @HostListener('keydown', ['$event'])
     keydownHandler(event: KeyboardEvent): void {
@@ -82,4 +90,11 @@ export class NotificationGroupHeaderComponent extends NotificationGroupBaseDirec
     toggleExpand(): void {
         this.expanded.update((expanded) => !expanded);
     }
+
+    /** @hidden */
+    ngOnInit(): void {
+        this._lang$.pipe(takeUntilDestroyed(this._destroyRef)).subscribe((lang: FdLanguage) => {
+            this.title.set(this._translationResolver.resolve(lang, 'coreNotification.groupHeaderTitle'));
+        });
+    }
 }
diff --git a/libs/core/notification/notification-group/notification-group.component.spec.ts b/libs/core/notification/notification-group/notification-group.component.spec.ts
@@ -71,7 +71,7 @@ describe('NotificationGroupComponent', () => {
 
     it('should affect the aria-description when aria-expanded changes', () => {
         const attributeElement = fixture.debugElement.query(By.css('fd-notification-group'));
-        expect(attributeElement.nativeElement.getAttribute('aria-description')).toBe('Notification group expanded');
+        expect(attributeElement.nativeElement.getAttribute('aria-description')).toBe('Notification Group expanded');
     });
 
     it('should set aria-labelledby from fd-notification-group-header-title child element', () => {