Merge branch 'main' into 10729-table-border-fix

SAP · Oct 21, 2024 · 31ea644 · 31ea644
2 parents 835c0e5 + ccb85f3
commit 31ea644
Show file tree

Hide file tree

Showing 43 changed files with 412 additions and 42 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,50 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.17](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.16...v0.53.1-rc.17) (2024-10-18)
+
+
+### Features
+
+* **platform:** form-generator Add support for dynamic width in `Select` component through width property ([#12557](https://github.com/SAP/fundamental-ngx/issues/12557)) ([29d4510](https://github.com/SAP/fundamental-ngx/commit/29d451068cd1bd1563a48d41d66326585a01fa18)), closes [#12302](https://github.com/SAP/fundamental-ngx/issues/12302)
+
+
+
+
+
+## [0.53.1-rc.16](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.15...v0.53.1-rc.16) (2024-10-18)
+
+
+### Bug Fixes
+
+* **core, platform:** add custom IDs to Setting Generator list items ([#12593](https://github.com/SAP/fundamental-ngx/issues/12593)) ([0e9a4f1](https://github.com/SAP/fundamental-ngx/commit/0e9a4f1f6a6c823dd6422a98bd810df5fc4dbc8a))
+
+
+
+
+
+## [0.53.1-rc.15](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.14...v0.53.1-rc.15) (2024-10-18)
+
+
+### Bug Fixes
+
+* **platform:** aria improvements to table cell header popover ([#12551](https://github.com/SAP/fundamental-ngx/issues/12551)) ([6f14ebd](https://github.com/SAP/fundamental-ngx/commit/6f14ebd6413324364a1429861aa4592ce7d4f68e))
+
+
+
+
+
+## [0.53.1-rc.14](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.13...v0.53.1-rc.14) (2024-10-18)
+
+
+### Bug Fixes
+
+* **core:** remove role="dialog" from dialog body in docs ([#12550](https://github.com/SAP/fundamental-ngx/issues/12550)) ([42a2589](https://github.com/SAP/fundamental-ngx/commit/42a2589730d08a0b2ace99155b5d22ad34683d7d))
+
+
+
+
+
 ## [0.53.1-rc.13](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.12...v0.53.1-rc.13) (2024-10-17)
 
 

diff --git a/lerna.json b/lerna.json
@@ -1,7 +1,7 @@
 {
     "$schema": "node_modules/lerna/schemas/lerna-schema.json",
     "packages": ["libs/*"],
-    "version": "0.53.1-rc.13",
+    "version": "0.53.1-rc.17",
     "conventionalCommits": true,
     "tagVersionPrefix": "v",
     "message": "chore(release): publish %v",

diff --git a/libs/btp/CHANGELOG.md b/libs/btp/CHANGELOG.md
@@ -3,6 +3,38 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.17](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.16...v0.53.1-rc.17) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/btp
+
+
+
+
+
+## [0.53.1-rc.16](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.15...v0.53.1-rc.16) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/btp
+
+
+
+
+
+## [0.53.1-rc.15](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.14...v0.53.1-rc.15) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/btp
+
+
+
+
+
+## [0.53.1-rc.14](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.13...v0.53.1-rc.14) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/btp
+
+
+
+
+
 ## [0.53.1-rc.13](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.12...v0.53.1-rc.13) (2024-10-17)
 
 **Note:** Version bump only for package @fundamental-ngx/btp

diff --git a/libs/btp/package.json b/libs/btp/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@fundamental-ngx/btp",
-    "version": "0.53.1-rc.13",
+    "version": "0.53.1-rc.17",
     "peerDependencies": {
         "@angular/common": "ANGULAR_VER_PLACEHOLDER",
         "@angular/core": "ANGULAR_VER_PLACEHOLDER",

diff --git a/libs/cdk/CHANGELOG.md b/libs/cdk/CHANGELOG.md
@@ -3,6 +3,38 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.17](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.16...v0.53.1-rc.17) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/cdk
+
+
+
+
+
+## [0.53.1-rc.16](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.15...v0.53.1-rc.16) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/cdk
+
+
+
+
+
+## [0.53.1-rc.15](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.14...v0.53.1-rc.15) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/cdk
+
+
+
+
+
+## [0.53.1-rc.14](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.13...v0.53.1-rc.14) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/cdk
+
+
+
+
+
 ## [0.53.1-rc.13](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.12...v0.53.1-rc.13) (2024-10-17)
 
 **Note:** Version bump only for package @fundamental-ngx/cdk

diff --git a/libs/cdk/package.json b/libs/cdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@fundamental-ngx/cdk",
-  "version": "0.53.1-rc.13",
+  "version": "0.53.1-rc.17",
   "schematics": "./schematics/collection.json",
   "description": "Fundamental Library for Angular - CDK",
   "license": "Apache-2.0",

diff --git a/libs/core/CHANGELOG.md b/libs/core/CHANGELOG.md
@@ -3,6 +3,41 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.17](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.16...v0.53.1-rc.17) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/core
+
+
+
+
+
+## [0.53.1-rc.16](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.15...v0.53.1-rc.16) (2024-10-18)
+
+
+### Bug Fixes
+
+* **core, platform:** add custom IDs to Setting Generator list items ([#12593](https://github.com/SAP/fundamental-ngx/issues/12593)) ([0e9a4f1](https://github.com/SAP/fundamental-ngx/commit/0e9a4f1f6a6c823dd6422a98bd810df5fc4dbc8a))
+
+
+
+
+
+## [0.53.1-rc.15](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.14...v0.53.1-rc.15) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/core
+
+
+
+
+
+## [0.53.1-rc.14](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.13...v0.53.1-rc.14) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/core
+
+
+
+
+
 ## [0.53.1-rc.13](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.12...v0.53.1-rc.13) (2024-10-17)
 
 

diff --git a/libs/core/combobox/combobox.component.html b/libs/core/combobox/combobox.component.html
@@ -11,6 +11,7 @@
         [triggers]="triggers"
         [disabled]="disabled || readOnly"
         [maxWidth]="640"
+        [style.width]="width && '100%'"
         [closeOnOutsideClick]="closeOnOutsideClick"
     >
         <fd-popover-control>

diff --git a/libs/core/combobox/combobox.component.ts b/libs/core/combobox/combobox.component.ts
@@ -111,7 +111,8 @@ let comboboxUniqueId = 0;
     host: {
         '[class.fd-combobox-custom-class]': 'true',
         '[class.fd-combobox-input]': 'true',
-        '[class.fd-combobox-custom-class--mobile]': 'mobile'
+        '[class.fd-combobox-custom-class--mobile]': 'mobile',
+        '[style.width]': 'width'
     },
     encapsulation: ViewEncapsulation.None,
     changeDetection: ChangeDetectionStrategy.OnPush,
@@ -244,6 +245,10 @@ export class ComboboxComponent<T = any>
     @Input()
     maxHeight = '50vh';
 
+    /** Custom width of the control. */
+    @Input()
+    width: Nullable<string>;
+
     /** Search function to execute when the Enter key is pressed on the main input. */
     @Input()
     searchFn: () => void;

diff --git a/libs/core/list/list-item/list-item.component.ts b/libs/core/list/list-item/list-item.component.ts
@@ -111,7 +111,7 @@ export class ListItemComponent<T = any> extends ListFocusItem<T> implements Afte
 
     /** The ID of the list item element */
     @Input()
-    id = 'fd-list-item-' + ++listItemUniqueId;
+    id: Nullable<string> = 'fd-list-item-' + ++listItemUniqueId;
 
     /** @hidden Implementation of KeyboardSupportItemInterface | TODO Revisit KeyboardSupportItemInterface*/
     @Output()

diff --git a/libs/core/package.json b/libs/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@fundamental-ngx/core",
-  "version": "0.53.1-rc.13",
+  "version": "0.53.1-rc.17",
   "schematics": "./schematics/collection.json",
   "ng-update": {
     "migrations": "./schematics/migrations.json"

diff --git a/libs/cx/CHANGELOG.md b/libs/cx/CHANGELOG.md
@@ -3,6 +3,38 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.17](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.16...v0.53.1-rc.17) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/cx
+
+
+
+
+
+## [0.53.1-rc.16](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.15...v0.53.1-rc.16) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/cx
+
+
+
+
+
+## [0.53.1-rc.15](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.14...v0.53.1-rc.15) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/cx
+
+
+
+
+
+## [0.53.1-rc.14](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.13...v0.53.1-rc.14) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/cx
+
+
+
+
+
 ## [0.53.1-rc.13](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.12...v0.53.1-rc.13) (2024-10-17)
 
 **Note:** Version bump only for package @fundamental-ngx/cx

diff --git a/libs/cx/package.json b/libs/cx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@fundamental-ngx/cx",
-  "version": "0.53.1-rc.13",
+  "version": "0.53.1-rc.17",
   "schematics": "./schematics/collection.json",
   "description": "Fundamental Library for Angular - cx",
   "license": "Apache-2.0",

diff --git a/libs/datetime-adapter/CHANGELOG.md b/libs/datetime-adapter/CHANGELOG.md
@@ -3,6 +3,38 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.53.1-rc.17](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.16...v0.53.1-rc.17) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/datetime-adapter
+
+
+
+
+
+## [0.53.1-rc.16](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.15...v0.53.1-rc.16) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/datetime-adapter
+
+
+
+
+
+## [0.53.1-rc.15](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.14...v0.53.1-rc.15) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/datetime-adapter
+
+
+
+
+
+## [0.53.1-rc.14](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.13...v0.53.1-rc.14) (2024-10-18)
+
+**Note:** Version bump only for package @fundamental-ngx/datetime-adapter
+
+
+
+
+
 ## [0.53.1-rc.13](https://github.com/SAP/fundamental-ngx/compare/v0.53.1-rc.12...v0.53.1-rc.13) (2024-10-17)
 
 **Note:** Version bump only for package @fundamental-ngx/datetime-adapter

diff --git a/libs/datetime-adapter/package.json b/libs/datetime-adapter/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@fundamental-ngx/datetime-adapter",
-    "version": "0.53.1-rc.13",
+    "version": "0.53.1-rc.17",
     "description": "Datetime adapter for SAP Fundamentals, based on Day.js package",
     "license": "Apache-2.0",
     "homepage": "https://sap.github.io/fundamental-ngx/home",

diff --git a/libs/docs/core/combobox/examples/combobox-example.component.html b/libs/docs/core/combobox/examples/combobox-example.component.html
@@ -1,10 +1,11 @@
 <div class="examples-column">
     <div fd-form-item>
-        <label fd-form-label for="comboboxID1">Standard</label>
+        <label fd-form-label for="comboboxID1">Standard with custom width</label>
         <fd-combobox
             inputId="comboboxID1"
             ariaLabel="Standard"
             maxHeight="250px"
+            width="300px"
             placeholder="Type some text..."
             [dropdownValues]="fruits"
             [(ngModel)]="searchTermOne"
@@ -87,4 +88,18 @@
         </fd-combobox>
     </div>
     <small>Search Term: {{ searchTermSix }}</small>
+
+    <div fd-form-item>
+        <label fd-form-label for="comboboxID1">Standard</label>
+        <fd-combobox
+            inputId="comboboxID1"
+            ariaLabel="Standard"
+            maxHeight="250px"
+            placeholder="Type some text..."
+            [dropdownValues]="fruits"
+            [(ngModel)]="searchTermOne"
+        >
+        </fd-combobox>
+    </div>
+    <small>Search Term: {{ searchTermOne }}</small>
 </div>
diff --git a/libs/docs/core/dialog/dialog-docs.component.html b/libs/docs/core/dialog/dialog-docs.component.html
@@ -221,7 +221,7 @@ <h1 fd-title id="fd-dialog-header-11">Playground Dialog</h1>
             <button fd-dialog-close-button (click)="dialog.dismiss()" title="close"></button>
         </fd-dialog-header>
         <fd-dialog-body>
-            <p id="fd-dialog-body-11" role="dialog">This is the dialog playground body text!</p>
+            <p id="fd-dialog-body-11">This is the dialog playground body text!</p>
         </fd-dialog-body>
         <fd-dialog-footer>
             <fd-button-bar fdType="emphasized" label="Close" (click)="dialog.close()" ariaLabel="Close Emphasized">

diff --git a/libs/docs/core/dialog/examples/auto-label/auto-label-dialog-example.component.html b/libs/docs/core/dialog/examples/auto-label/auto-label-dialog-example.component.html
@@ -5,7 +5,7 @@ <h1 id="fd-dialog-header-10" fd-title fd-dialog-title>The History of Pineapple</
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <div id="fd-dialog-body-10" role="dialog">Are you interested in The Great History of Pineapple?</div>
+            <div id="fd-dialog-body-10">Are you interested in The Great History of Pineapple?</div>
         </fd-dialog-body>
 
         <fd-dialog-footer>

diff --git a/libs/docs/core/dialog/examples/component-based/dialog-example.component.ts b/libs/docs/core/dialog/examples/component-based/dialog-example.component.ts
@@ -20,7 +20,7 @@ import { TitleComponent } from '@fundamental-ngx/core/title';
                 <h1 id="fd-dialog-header-1" fd-title>{{ dialogRef.data.title }}</h1>
             </fd-dialog-header>
             <fd-dialog-body>
-                <p id="fd-dialog-body-1" role="dialog" [ngStyle]="{ 'text-align': 'justify', margin: 0 }">
+                <p id="fd-dialog-body-1" [ngStyle]="{ 'text-align': 'justify', margin: 0 }">
                     {{ dialogRef.data.pinnapleDescription }}
                 </p>
                 <ul [style.margin-bottom]="0">