Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a doc section for harmonised API #225

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

jjtang1985
Copy link
Contributor

To highlight the harmonised API, we should mention this explicitly.

Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion

>
> #### Harmonized API
>
> You can switch to a different model, even from another vendor, by leveraging the harmonized API of the orchestration service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> You can switch to a different model, even from another vendor, by leveraging the harmonized API of the orchestration service.
> As the orchestration service API is harmonized, you can switch to a different model, even from another vendor, by changing only the `model_name` property.
> All other configurations remain the same.

> #### Harmonized API
>
> You can switch to a different model, even from another vendor, by leveraging the harmonized API of the orchestration service.
> Here’s an example where only one line of code is changed..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Here’s an example where only one line of code is changed..
> Here’s an example where only one line of code is changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pp] Not sure if it is necessary to provide a complete example here just for changing a property. It feels hard to emphasize this advantage on written text unlike seeing a line change in a real demo.

@jjtang1985 jjtang1985 merged commit 86c3a0f into main Oct 21, 2024
10 checks passed
@jjtang1985 jjtang1985 deleted the add-harmonised-api branch October 21, 2024 07:52
@jjtang1985 jjtang1985 mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants