Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Docs add model version and api version #188

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

ZhongpinWang
Copy link
Contributor

Context

AI/gen-ai-hub-sdk-js-backlog#139.

Add documentation for

  • setting model_version in orchestration
  • the used Azure OpenAI API version
  • setting requestConfig in
    • Azure OpenAI client
    • orchestration client

Definition of Done

  • [ ] Code is tested (Unit, E2E)
  • [ ] Error handling created / updated & covered by the tests above
  • Documentation updated
  • [ ] (Optional) Aligned changes with the Java SDK
  • [ ] (Optional) Release notes updated

@ZhongpinWang ZhongpinWang mentioned this pull request Oct 1, 2024
5 tasks
Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ZhongpinWang ZhongpinWang merged commit 189a238 into main Oct 2, 2024
9 checks passed
@ZhongpinWang ZhongpinWang deleted the docs-add-model-version-and-api-version branch October 2, 2024 10:18
Comment on lines +84 to +97
const response = await orchestrationClient.chatCompletion(
{
inputParams: { country: 'France' }
},
{
headers: {
// Add more headers here
},
params: {
// Add more parameters here
}
// Add more request configuration here
}
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this under a section Customizing the Request Configuration ?

Copy link
Contributor Author

@ZhongpinWang ZhongpinWang Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants