Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Run test coverage check locally #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

newtork
Copy link
Contributor

@newtork newtork commented Oct 24, 2024

Context

  • Run jacoco check for every clean install
  • Move thresholds to pom.xml
  • Remove redundant workflow step and python file
  • Increase thresholds

Sample output:

mvn clean install

[...]

[INFO] --- jacoco:0.8.12:check (default-check) @ openai ---
[INFO] Loading execution data file C:\SAPDevelop\ai-sdk-java\foundation-models\openai\target\jacoco.exec
[INFO] Analyzed bundle 'openai' with 42 classes
[WARNING] Rule violated for bundle openai: instructions covered ratio is 0.74, but expected minimum is 0.79
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for SAP AI SDK - Parent POM 0.2.0-SNAPSHOT:
[INFO] 
[INFO] SAP AI SDK - Parent POM ............................ SUCCESS [  3.126 s]
[INFO] AI Core client ..................................... SUCCESS [ 31.307 s]
[INFO] Orchestration client ............................... SUCCESS [  9.072 s]
[INFO] OpenAI client ...................................... FAILURE [ 10.729 s]
[INFO] End-to-end test application ........................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  54.395 s
[INFO] Finished at: 2024-10-24T15:18:09+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.12:check (default-check) on project openai: Coverage checks have not been met. See log for details. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

@newtork newtork changed the title [CI/CD] Run coverage check locally [CI/CD] Run test coverage check locally Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants