feat: Orchestration client #114
Conversation
| @@ -0,0 +1,3 @@ | |||
| package com.sap.ai.sdk.orchestration; | |||
|
|
|||
| public sealed interface ContentFilter permits AzureContentFilter {} | |||
There was a problem hiding this comment.
Sealed is quite useful here, as this is a marker interface, and users can't supply their own implementations, because we wouldn't have the implementation to translate those to DTOs.
With a higher Java version, we could even switch over implementations of the interface. That has the nice benefit that the compiler can force us to handle all implementations. But only with Java 21 🤷🏻
| } | ||
|
|
||
| @Nonnull | ||
| com.sap.ai.sdk.orchestration.client.model.FilterConfig toFilterConfigDTO() { |
There was a problem hiding this comment.
I tried to consistently label the DTOs as such in the code, so that it's always obvious when we are (preparing) (de-) serialization
| public interface OrchestrationConfig<T extends OrchestrationConfig<T>> { | ||
|
|
||
| @Nonnull | ||
| Option<AiModel> getLlmConfig(); |
There was a problem hiding this comment.
Debatable, if we want to keep VAVR in our public API. Done here for now because this makes our own code (arguably) much more beautiful 😄
Alternatives would be Java Optional or just @Nullable.
| import lombok.RequiredArgsConstructor; | ||
| import lombok.val; | ||
|
|
||
| public record OrchestrationResponse( |
There was a problem hiding this comment.
Debatable if this should be a record or not. The AllArgs constructor is a bit awkward. Also, we might offer more convenience later on..
|
|
||
| public record OrchestrationResponse( | ||
| @Nonnull ChatMessage assistantMessage, | ||
| @Nonnull List<ChatMessage> allMessages, |
There was a problem hiding this comment.
allMessages is a notable convenience for end users, this is not natively included in the orchestration response, but needed for chat scenarios or in general for an easy display of prompt + response.
| Map.of( | ||
| "orgCV", | ||
| """ | ||
| Patrick Morgan |
There was a problem hiding this comment.
While this is a nice example in principal, I felt that it is too large to properly see the relationship between masking config, prompt and result.
Also, I'm not sure if applying all masking profiles is a good idea.
|
|
||
| @RequiredArgsConstructor | ||
| public enum Sensitivity { | ||
| HIGH(0), |
There was a problem hiding this comment.
Naming aligned w/ Orchestration team, to be aligned w/ JS and Launchpad
Context
This PR introduces a completely new API for orchestration.
Feature scope:
AiModelConvenience for message historyraised a feature request to enable this hereTODO
@Betaand (maybe?) rename model package todtoDefinition of Done