[EDCK] Add new object type for EDCK

[KUMARMUKULSAP]

No description provided.

[cla-assistant]

All committers have signed the CLA.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[GuilhermeSaraiva96]

Hi, thank you for the contribution! Do not mind the amount of comments, they are basically all the same. We have some guidelines on how the title and description are written: sentence case for descriptions (only the very first letter is capital) (https://github.com/SAP/abap-file-formats/blob/main/docs/json.md#description)

[GuilhermeSaraiva96]

Furthermore, the example object is missing

[Markus1812]

Thank you for resolving the comments above. We have looked over it again and found some minor issues again. Please take a look.

You are also missing an example. If you could add one with the name z_aff_example_edck.edck.json in an examples folder and link it in the README.md.

[KUMARMUKULSAP]

@Markus1812 : I have incorporated all above review comments. However, I am stuck at the check Generated Json Schema differs from provided ones. I am not really sure how to resolve this error. I cannot find out from where I can download the generated JSON schema to perform the comparison with the provided JSON schema. Please help.

[Markus1812]

Took me some while to find the cause for the schema mismatch but with the first two suggestions it should work now.
The other two are some minor issues with title case.

In one of the commits, you committed a .DS_Store file. Can you please remove it again?

[KUMARMUKULSAP]

@Markus1812 : Thank you for helping out. I have incorporated the review comments. and deleted the .DS_Store file as well. Please approve.

[Markus1812]

In case you have missed it: One comment above is still unresolved. There was not only the z missing of zif... missing but also the exist has to be existence_check to be the same as the constant name.

#629 (comment)

[KUMARMUKULSAP]

@Markus1812 : Constant name of the default value has been corrected as well. Let me know if further changes are required.

[Markus1812]

Looks good to me now, thank you. In the next step, the ux-review team will take over.

[wurzka]

Hi @KUMARMUKULSAP, please see my comments. In addition to the boolean we already discussed, I found some mismatches between title and name of the component

[KUMARMUKULSAP]

@wurzka : Requested changes are done.

[wurzka]

Thanks for the updates @KUMARMUKULSAP!
Just one minor, else looks good to me.

[wurzka]

Thanks for providing the last change. Looks good to me!

[schneidermic0]

@KUMARMUKULSAP welcome as contributor :)