[GSMG] Add new object type #593
Conversation
There was a problem hiding this comment.
Hi @mseich, thanks for uploading the GSMG file format! Please see my comments below.
I'm afraid I didn't express myself precisely enough with regard to the descriptions when we talked about it. They should be in sentence case, but the titles (the shorttexts) in title case.
| }, | ||
| "generalInformation": { | ||
| "type": "USAGE", | ||
| "detailedDescription": "This Metric Group is for testing" |
There was a problem hiding this comment.
What is this description about? Is it an extension of the description field in the header? So like the name says, is it for describing the object in more detail than the header-description allows?
There was a problem hiding this comment.
Just some additional questions: Did you thought about extending the standard description to 255 characters. As far as I know, this should be possible.
If it is more a documentation. Did you consider to provide documentation using KTD?
Co-authored-by: Albert Mink <[email protected]>
Co-authored-by: Katharina Wurz <[email protected]>
Co-authored-by: Katharina Wurz <[email protected]>
Co-authored-by: Katharina Wurz <[email protected]>
Co-authored-by: Katharina Wurz <[email protected]>
Co-authored-by: Katharina Wurz <[email protected]>
Co-authored-by: Katharina Wurz <[email protected]>
Co-authored-by: Katharina Wurz <[email protected]>
Switched type to category
There was a problem hiding this comment.
In general, it looks quite good. Just some minor issues.
Please see also my question regarding the detailedDescription. I followed-up on @wurzka's question. (see above)
| }, | ||
| "generalInformation": { | ||
| "type": "USAGE", | ||
| "detailedDescription": "This Metric Group is for testing" |
There was a problem hiding this comment.
Just some additional questions: Did you thought about extending the standard description to 255 characters. As far as I know, this should be possible.
If it is more a documentation. Did you consider to provide documentation using KTD?
Co-authored-by: Michael Schneider <[email protected]>
Co-authored-by: Michael Schneider <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
|
@mseich @albertmink As far as I can see the UX cross check did took place. I see only one open question. Should the order of If it is fine as it is now (non-alphabetic), I think, we could merge this PR. |
No description provided.