[SIAD]Add file format #572
Conversation
|
|
|
Leibfried seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| "! <p class="shorttext">Business Role Template ID</p> | ||
| "! Business Role Template ID | ||
| "! $required | ||
| BusinessRoleTemplateID TYPE aps_iam_brt_id, |
There was a problem hiding this comment.
we prefer primitive data types (towards self contained, assuming basic types as char are known), so aps_iam_brt_id is a char[30] right?
| "! <p class="shorttext">Business Role Template ID</p> | ||
| "! Business role template ID | ||
| "! $required | ||
| business_role_template_id TYPE c LENGTH 30, |
There was a problem hiding this comment.
Is fine for me. Just two minor remarks:
- In most cases, we call it object names (instead of their ID). Maybe, we can even skip it at all (I guess this would be my preferred solution) However, I would take this to the UX review what they think.
- As mentioned before, for object names with the length of 30 we already provide a generic type which you can reuse:
zif_aff_types_v1=>ty_object_name_30(orif_aff_types_v1=>ty_object_name_30within SAP systems)
| "! <p class="shorttext">General</p> | ||
| "! General | ||
| "! $required | ||
| assignment TYPE ty_assignment, |
There was a problem hiding this comment.
What do you want to emphasise. Do developers specify "general information" or the "assignments" of the object?
There was a problem hiding this comment.
We compared our editor with other editors of us and we always have this "General" at top in other editors.
But you are right developers specify more the "assignments" of the object, so "Assignment" would be better?
There was a problem hiding this comment.
Yes, "General Information" is used, if we are not able to find a better semantic name. If there is a more specific name, we suggest to use this one. See second-last paragraph of https://github.com/SAP/abap-file-formats/blob/main/docs/json.md#writing-json-schema-with-abap-types
I am not sure, maybe, it's even "Assignements" because there are multiple assignments (to the business role template and to the space template)? It's not an assignment between business role template and space template, is it? What do you think?
There was a problem hiding this comment.
I think general information would be the best choice, the whole object is an assignment of a business role template and a space template, so if it would be "Assignment(s)" this would be a duplicate and makes not that much sense in this position.
No description provided.