Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added example object to ILMB folder #571

Merged
merged 8 commits into from
Nov 16, 2023
Merged

added example object to ILMB folder #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d73fb21
added example object to ILMB folder
srnawaz Nov 14, 2023
4def4ac
File Renamed to z_aff_example_ilmb.ilmb.json
srnawaz Nov 14, 2023
a5fe87d
File renamed and required annotations removed
srnawaz Nov 14, 2023
4c940a2
checkmarx changes failed
srnawaz Nov 14, 2023
b7f4da8
Fixing checkmarx issues
srnawaz Nov 14, 2023
76aacf2
Removal of annotations destruction object and callback class
srnawaz Nov 15, 2023
7a094d9
Annotation Changes
srnawaz Nov 15, 2023
96431d1
Update to ILMB-v1 JSON
srnawaz Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion file-formats/ilmb/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.ilmb.json` | 1 | [`zif_aff_ilmb_v1.intf.abap`](./type/zif_aff_ilmb_v1.intf.abap) | [`ilmb-v1.json`](./ilmb-v1.json)
`<name>.ilmb.json` | 1 | [`zif_aff_ilmb_v1.intf.abap`](./type/zif_aff_ilmb_v1.intf.abap) | [`ilmb-v1.json`](./ilmb-v1.json) | [z_aff_example_ilmb.ilmb.json](./examples/z_aff_example_ilmb.ilmb.json)
67 changes: 67 additions & 0 deletions file-formats/ilmb/examples/z_aff_example_ilmb.ilmb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
{
"formatVersion": "1",
"header": {
"description": "Sample ILM Object (Flight Model)",
"originalLanguage": "en"
},
"timeReferences": [
{
"timeReference": "CREATION_DATE",
"sourceTable": "SFLIGHT",
"sourceField": "FLDATE"
},
{
"timeReference": "Z_FIXED_DATE",
"sourceTable": "SFLIGHT",
"sourceField": "FLDATE",
"indirectValue": true
}
],
"conditionFields": [
{
"conditionField": "CARRID_1",
"dataElement": "S_CARRID",
"sourceTable": "SFLIGHT",
"sourceField": "CARRID",
"noIntervals": true
},
{
"conditionField": "CONNID",
"dataElement": "CONNID",
"sourceTable": "SFLIGHT",
"sourceField": "CONNID",
"noIntervals": true
},
{
"conditionField": "COUNTRY",
"dataElement": "LAND1",
"sourceTable": "SFLIGHT",
"sourceField": "CARRID",
"indirectValue": true,
"noIntervals": true
},
{
"conditionField": "COUNTRY",
"dataElement": "LAND1",
"sourceTable": "SFLIGHT",
"sourceField": "CONNID",
"indirectValue": true,
"noIntervals": true
},
{
"conditionField": "COUNTRY",
"dataElement": "LAND1",
"sourceTable": "SFLIGHT",
"sourceField": "FLDATE",
"indirectValue": true,
"noIntervals": true
},
{
"conditionField": "CURRENCY",
"dataElement": "S_CURRCODE",
"sourceTable": "SFLIGHT",
"sourceField": "CURRENCY",
"noIntervals": true
}
]
}
4 changes: 1 addition & 3 deletions file-formats/ilmb/ilmb-v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,7 @@
"required": [
"formatVersion",
"header",
"destructionObject",
"timeReferences",
"conditionFields",
"callbackClass"
"conditionFields"
]
}
2 changes: 0 additions & 2 deletions file-formats/ilmb/type/zif_aff_ilmb_v1.intf.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ INTERFACE zif_aff_ilmb_v1
header TYPE zif_aff_types_v1=>ty_header_60_cloud,
"! <p class="shorttext">Destruction Object</p>
"! Mapping ILM object to data destruction object
"! $required
destruction_object TYPE ty_destruction_object,
"! <p class="shorttext">Time References</p>
"! Value determination for time references
Expand All @@ -101,7 +100,6 @@ INTERFACE zif_aff_ilmb_v1
condition_fields TYPE ty_cond_fields,
"! <p class="shorttext">Value Determination Callback Class</p>
"! Value determination callback class
"! $required
callback_class TYPE ty_callback_class,
END OF ty_main.

Expand Down
Loading