Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix titles and descriptions for DMON, RONT, NONT #565

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

schneidermic0
Copy link
Contributor

@schneidermic0 schneidermic0 commented Oct 26, 2023

Object types DMON, RONT and NONT did not specify a title or description for ty_main. For this reason the JSON schema has neither a title nor a description.

See #561

@schneidermic0 schneidermic0 marked this pull request as ready for review October 26, 2023 14:24
Copy link
Collaborator

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schneidermic0
Copy link
Contributor Author

closes #561

@schneidermic0
Copy link
Contributor Author

Thanks @larshp for your review. I am waiting for input by @Ehret-Thomas until the end of the day. Latest then, I will merge it. If more changes are required (because @Ehret-Thomas does not manage to look into it, today), we could also add them later.

@larshp
Copy link
Collaborator

larshp commented Oct 27, 2023

no hurry

Copy link
Contributor

@Ehret-Thomas Ehret-Thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this! LGTM, too 👍

@schneidermic0 schneidermic0 merged commit 100d201 into main Oct 27, 2023
8 checks passed
@schneidermic0 schneidermic0 deleted the fix/titles-and-descriptions branch October 27, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants