Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDBO] Change Value for CDS Types #549

Merged
merged 6 commits into from
Aug 16, 2023
Merged

[CDBO] Change Value for CDS Types #549

merged 6 commits into from
Aug 16, 2023
+6 −5

Conversation

ABEDI30
Copy link
Contributor

@ABEDI30 ABEDI30 commented Aug 14, 2023

We have update the CDBO Type for CDS Views from 2 to 3 .

@schneidermic0 schneidermic0 changed the title update_cdbo_new [CDBO] Change Value for CDS Types Aug 14, 2023
@albertmink
Copy link
Contributor

@ABEDI30 besides the change from 02 to 03 you propose to change the name of the example file. Most, if not all, examples are in customer namespace. Can you explain?

@huber-nicolas
Copy link
Contributor

@ABEDI30 besides the change from 02 to 03 you propose to change the name of the example file. Most, if not all, examples are in customer namespace. Can you explain?

Is fixed now. We created a Z example object in the system

schneidermic0
schneidermic0 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your explanations. Then, your change looks fine to me.

albertmink
albertmink approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@huber-nicolas huber-nicolas merged commit 712b303 into SAP:main Aug 16, 2023
7 checks passed
huber-nicolas added a commit that referenced this pull request Aug 22, 2023
@huber-nicolas
Revert "[CDBO] Change Value for CDS Types (#549)"
4999a31 
This reverts commit 712b303.
@huber-nicolas huber-nicolas mentioned this pull request Aug 22, 2023
Merged
huber-nicolas added a commit that referenced this pull request Aug 22, 2023
@huber-nicolas
Revert "[CDBO] Change Value for CDS Types (#549)" (#552)
c0a5bf7 
This reverts commit 712b303.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huber-nicolas huber-nicolas huber-nicolas left review comments

@albertmink albertmink albertmink approved these changes

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ABEDI30 @albertmink @huber-nicolas @schneidermic0