Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UIST] Update: Replace Base Template Id with Merge Id #548

Merged
merged 31 commits into from
Aug 15, 2023
Merged

[UIST] Update: Replace Base Template Id with Merge Id #548

merged 31 commits into from
Aug 15, 2023

Conversation

ViktoriaFreidel
Copy link
Contributor

We replace a Field for Base Template ID wit a Merge ID. This is only one correction.

ViktoriaFreidel and others added 29 commits March 14, 2023 10:48
@ViktoriaFreidel
[UIST] Add new object type UIST
86a006e
@ViktoriaFreidel
[UIST] Add new object type UIST
995af5b
@ViktoriaFreidel @schneidermic0
Update file-formats/uist/type/zif_aff_uist_v1.intf.abap
2d90847 
Co-authored-by: Michael Schneider <[email protected]>
@ViktoriaFreidel @wurzka
Update file-formats/uist/type/zif_aff_uist_v1.intf.abap
9019fda 
Ok. It maybe is a reason why I got a warning message about a format version in generation report.

Co-authored-by: Katharina Wurz <[email protected]>
@ViktoriaFreidel
Add new object type UIST
7ffbc3b
@ViktoriaFreidel
Add new object type UIST
35af4b6
@ViktoriaFreidel
[UIST] Add new object type UIST
74d39a7
@schneidermic0
Merge branch 'main' into feature/uist
12ace5f
@wurzka
Add header 100 for cloud
47de50c
@ViktoriaFreidel @schneidermic0
Update /uist/type/zif_aff_uist_v1.intf.abap use cloud description
466821a 
Co-authored-by: Michael Schneider <[email protected]>
@ViktoriaFreidel @schneidermic0
Update zif_aff_uist_v1.intf.abap - use Name and not Id
2ad56b8 
Co-authored-by: Michael Schneider <[email protected]>
@ViktoriaFreidel @schneidermic0
Update zif_aff_uist_v1.intf.abap - use Page Name not Id
c81d390 
Co-authored-by: Michael Schneider <[email protected]>
@ViktoriaFreidel @schneidermic0
Update zif_aff_uist_v1.intf.abap- remove pages description and title
2869329 
Co-authored-by: Michael Schneider <[email protected]>
@ViktoriaFreidel
[UIST] Add new object type UIST and Update AFF Model
4ae86d1
@ViktoriaFreidel
[UIST] Add new object type UIST and Update AFF Model
b628fe0
@ViktoriaFreidel
[UIST] Add new object type UIST and Update AFF Model
ed1b79c
@ViktoriaFreidel
[UIST] Add new object type UIST and Update AFF Model
d8e19ab
@ViktoriaFreidel
[UIST] Add new object type UIST
1144999
@ViktoriaFreidel @schneidermic0
Update file-formats/uist/type/zif_aff_uist_v1.intf.abap
3c9d96e 
Co-authored-by: Michael Schneider <[email protected]>
@ViktoriaFreidel @schneidermic0
Update file-formats/uist/examples/z_aff_example_uist.uist.json
6514fe2 
Co-authored-by: Michael Schneider <[email protected]>
@ViktoriaFreidel @schneidermic0
Update file-formats/uist/type/zif_aff_uist_v1.intf.abap
6dc3e7a 
Co-authored-by: Michael Schneider <[email protected]>
@ViktoriaFreidel @huber-nicolas
Update file-formats/uist/type/zif_aff_uist_v1.intf.abap
c6975da 
Co-authored-by: Nicolas Huber <[email protected]>
@ViktoriaFreidel
[UIST] Add new object type UIST
6290642
@ViktoriaFreidel
[UIST] Add new object type UIST
2b8e327
@ViktoriaFreidel
[UIST] Add new object type UIST
942cda4
@schneidermic0
remove multipleOffrom schema
bf29b35
@schneidermic0
Merge branch 'main' into feature/uist
33860fe
@ViktoriaFreidel
Merge branch 'SAP:main' into feature/uist
060d694
@ViktoriaFreidel
Replace Base Space Id with Merge Id
5ad7022
@ViktoriaFreidel ViktoriaFreidel changed the title Feature/uist Update UIST: Replace Base Template Id with Merge Id Aug 10, 2023
@ViktoriaFreidel ViktoriaFreidel changed the title Update UIST: Replace Base Template Id with Merge Id [UIST] Update: Replace Base Template Id with Merge Id Aug 10, 2023
@schneidermic0
Copy link
Contributor

Can be still changed incompatible without updating the format version

schneidermic0
schneidermic0 previously approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @ViktoriaFreidel.

If "merge ID" is the right terminology, it looks good to me.

@schneidermic0 schneidermic0 self-requested a review August 11, 2023 06:32
@schneidermic0 schneidermic0 dismissed their stale review August 14, 2023 07:30

Open question wrt mergeId

schneidermic0
schneidermic0 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@schneidermic0 schneidermic0 merged commit 907b7a6 into SAP:main Aug 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikvonSchoenebeck DominikvonSchoenebeck DominikvonSchoenebeck left review comments

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktoriaFreidel @schneidermic0 @DominikvonSchoenebeck @wurzka