-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COTA] Add new object type COTA #543
Conversation
@WUEHR typically objects don't store its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WUEHR Thanks for your pull request
See my first comments below.
In general, please try to use understandable field names, because the file format is intended to be human readable. Usually we recommend to use the same field name you would choose for a field label on an UI (see https://github.com/SAP/abap-file-formats/blob/main/README.md#background-and-scope).
Please, also try to fix the issues reported by abaplint. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
Please see my comments. I guess a bunch of fields can still be removed.
If this is done, you might want to come up with a grouping of your fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all improvements. I have added some more questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, it looks good for me, now. However, some more issues to fix:
- I think the folder structure is still broken. There are two nested folders
cota
. (Example: file-formats/cota/cota/README.md)
I think this is also the reason for the failing JSON validation check. - Remove the example link from the readme or add an example to solve the failing link check
- Descriptions should be sentence style (see examples below and check the others, too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @WUEHR. Looks good to me, now.
A new open question appeared: enum with only one value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for update @WUEHR.
There are still some description issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) (from UX point of view)
We will have a discussion with RFC colleagues when Michael Acker is back from vacation -> please don't merge as long as the meeting did not take place Thank you :) |
Were you able to discuss the topic? How shall we proceed? |
Hello colleagues, the possibility of a language version change is not working yet but it is being registered by the language version team in the moment, I followed https://wiki.one.int.sap/wiki/display/ApplServ/ABAP+Language+Version+Development+Guideline. Thanks and best regards |
We've already talked about it: Showing and hiding individual fields depending on other fields will be possible at some point soon, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@WUEHR Welcome as contributor 🎉 |
No description provided.