[COTA] Add new object type COTA

[WUEHR]

No description provided.

[cla-assistant]

All committers have signed the CLA.

[albertmink]

@WUEHR typically objects don't store its changedby or changedat and others. This is considered meta data and redundant as explained https://github.com/SAP/abap-file-formats#background-and-scope

[schneidermic0]

@WUEHR Thanks for your pull request

See my first comments below.

In general, please try to use understandable field names, because the file format is intended to be human readable. Usually we recommend to use the same field name you would choose for a field label on an UI (see https://github.com/SAP/abap-file-formats/blob/main/README.md#background-and-scope).

Please, also try to fix the issues reported by abaplint. Thanks.

[schneidermic0]

Thanks for the updates.

Please see my comments. I guess a bunch of fields can still be removed.

If this is done, you might want to come up with a grouping of your fields.

[schneidermic0]

Thanks for all improvements. I have added some more questions

[schneidermic0]

Basically, it looks good for me, now. However, some more issues to fix:

1. I think the folder structure is still broken. There are two nested folders cota. (Example: file-formats/cota/cota/README.md)
   I think this is also the reason for the failing JSON validation check.
2. Remove the example link from the readme or add an example to solve the failing link check
3. Descriptions should be sentence style (see examples below and check the others, too)

[schneidermic0]

Thanks, @WUEHR. Looks good to me, now.

A new open question appeared: enum with only one value

[wurzka]

See my comments :)

[wurzka]

Thanks for update @WUEHR.
There are still some description issues.

[wurzka]

LGTM :) (from UX point of view)

[WUEHR]

We will have a discussion with RFC colleagues when Michael Acker is back from vacation -> please don't merge as long as the meeting did not take place

Thank you :)

[schneidermic0]

We will have a discussion with RFC colleagues when Michael Acker is back from vacation -> please don't merge as long as the meeting did not take place

Thank you :)

Were you able to discuss the topic? How shall we proceed?

[WUEHR]

Hello colleagues,

the possibility of a language version change is not working yet but it is being registered by the language version team in the moment, I followed https://wiki.one.int.sap/wiki/display/ApplServ/ABAP+Language+Version+Development+Guideline.
How is it possible to make fields visible depending on the language version? I haven't found anything about that in the docus.

Thanks and best regards
Frank

[WUEHR]

We've already talked about it: Showing and hiding individual fields depending on other fields will be possible at some point soon, right?

[schneidermic0]

Looks good to me.

[schneidermic0]

@WUEHR Welcome as contributor 🎉