Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SRVC] Add new object type SRVC #542

Merged
merged 9 commits into from
Aug 4, 2023
Merged

[SRVC] Add new object type SRVC #542

merged 9 commits into from
Aug 4, 2023
+237 −0

Conversation

praveen-skp
Copy link
Contributor

Change-Id: I086a03a758815c4bdc2bfb0dca8d947e325232f0

@praveen-skp
[SRVC] Add new object type SRVC
c10fa47 
Change-Id: I086a03a758815c4bdc2bfb0dca8d947e325232f0
@cla-assistant
Copy link

cla-assistant bot commented Jul 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

schneidermic0
schneidermic0 requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @praveen-skp. 👍

See my comments and questions.

file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Show resolved Hide resolved
file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Show resolved Hide resolved
file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/srvc/examples/z_aff_example_srvc.srvc.json Outdated Show resolved Hide resolved
file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Outdated Show resolved Hide resolved
@praveen-skp
Updated consumer information and consumer type
e3f2adf 
Change-Id: I9095eb81e11cb6b8e3d78d433ead63ac2985847b
@praveen-skp
Updated SRVC example
f0a08df 
Change-Id: I6fd42023735a81336da4930a1a30b1d60c6cca0d
schneidermic0
schneidermic0 requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @praveen-skp for all the improvements.

I added some follow-up comments and questions. I think they are mostly small improvements.

file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Outdated Show resolved Hide resolved
schneidermic0
schneidermic0 reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good, now. I found two minor issues. We can also discuss them later in our call

file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/srvc/type/zif_aff_srvc_v1.intf.abap Outdated Show resolved Hide resolved
@praveen-skp
[SRVC] Add new object type SRVC
85840fc 
Change-Id: I086a03a758815c4bdc2bfb0dca8d947e325232f0
@praveen-skp
Updated consumer information and consumer type
9dafb13 
Change-Id: I9095eb81e11cb6b8e3d78d433ead63ac2985847b
@praveen-skp
Updated consumer properties and removed HTTP consumer type
6098bcc 
Change-Id: Iae7559de130c1430d0d15fe7f66032d2f13f9a23
@praveen-skp
Added required fields for consumer type
bc7eed3 
Change-Id: I31d6bf6b41eda6053dc5f4dedfdc1a6b89024d6d
schneidermic0
schneidermic0 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @praveen-skp. Looks good to me, now. 👍

@schneidermic0 schneidermic0 merged commit 7fae4c9 into SAP:main Aug 4, 2023
7 checks passed
@schneidermic0
Copy link
Contributor

@praveen-skp Welcome as contributor 👍

@praveen-skp praveen-skp deleted the feature/srvc branch August 7, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praveen-skp @schneidermic0