-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SRVC] Add new object type SRVC #542
Conversation
Change-Id: I086a03a758815c4bdc2bfb0dca8d947e325232f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @praveen-skp. 👍
See my comments and questions.
Change-Id: I9095eb81e11cb6b8e3d78d433ead63ac2985847b
Change-Id: I6fd42023735a81336da4930a1a30b1d60c6cca0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @praveen-skp for all the improvements.
I added some follow-up comments and questions. I think they are mostly small improvements.
Change-Id: Iae7559de130c1430d0d15fe7f66032d2f13f9a23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good, now. I found two minor issues. We can also discuss them later in our call
Change-Id: I086a03a758815c4bdc2bfb0dca8d947e325232f0
Change-Id: I9095eb81e11cb6b8e3d78d433ead63ac2985847b
Change-Id: Iae7559de130c1430d0d15fe7f66032d2f13f9a23
Change-Id: I31d6bf6b41eda6053dc5f4dedfdc1a6b89024d6d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @praveen-skp. Looks good to me, now. 👍
@praveen-skp Welcome as contributor 👍 |
Change-Id: I086a03a758815c4bdc2bfb0dca8d947e325232f0