-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ILMB] Add New Object ILMB #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @srnawaz. See my comments and questions below.
file-formats/ilmb/README.md
Outdated
|
||
File | Cardinality | Definition | Schema | Example | ||
:--- | :--- | :--- | :--- | :--- | ||
`<name>.ilmb.json` | 1 | [`zif_aff_ilmb_v1.intf.abap`](./type/zif_aff_ilmb_v1.intf.abap) | [`ilmb-v1.json`](./ilmb-v1.json) | [`z_aff_example_ilmb.ilmb.json`](./examples/z_aff_example_ilmb.ilmb.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have either to add the example or remove the link. This fixes the broken link build error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @srnawaz for the update. Please see my comments below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two issues with 'Details' in the title
Sorry, I haven't manage to look into the updated version, yet. I plan to look into it next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted the link to the missing example for the time being.
Looks good to me. It can be reviewed by @SAP/abap-file-formats-ux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We managed to perform UX Review. See my comments
"! <p class="shorttext">Condition Field Details</p> | ||
"! Condition field details | ||
BEGIN OF ty_cond_field, | ||
"! <p class="shorttext">Name</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have it in sync with time reference table:
"! <p class="shorttext">Name</p> | |
"! <p class="shorttext">Condition Field</p> |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two issues with the description: The description should be in sentence case and not in title case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, now 👍
I created a issue for not forgetting the example: #559 |
Adding ILMB Object to the GitHub Repository for UX Review