github actions: issue error if mismatch ABAP <> Schema

[larshp]

github action will now give an error if the ABAP code and generated schema does not match

Note that "Generate Schemas" is not a required status check, so it will not block merges

ENHO skipped due to #409

[schneidermic0]

github action will now give an error if the ABAP code and generated schema does not mismatch

I guess you mean if they "do not match" or "mismatch", don't you? ;)

[larshp]

fixed 😁

[schneidermic0]

Cool.

Looks good to me.
@SAP/abap-file-formats-team Would someone else review this PR, too?

[wurzka]

LGTM :)

[albertmink]

I like the integration. But maybe we can find a better name of the action?

It took me I while to find the action in this list

If the main purpose of the action is 'Check if ABAP type and JSON Schema align' then the 'Generate Schemas' is misleading. Actually it generates the JSON Schema but don't provide it as a download or other artefacts, right?

[schneidermic0]

If the main purpose of the action is 'Check if ABAP type and JSON Schema align' then the 'Generate Schemas' is misleading. Actually it generates the JSON Schema but don't provide it as a download or other artefacts, right?

Suggestions:

• Validate JSON schema against ABAP type
• Validate JSON schema

More suggestions are welcome :)

[larshp]

true, however, on longer term I'd suggest it to actually update the PR with the file

but anyhow, no trouble renaming it for now

[jhunni]

"Validate JSON schema against ABAP type" sounds good to me. However, the next check in the list is called "Validate JSON". Maybe rename this one, too, so it's clear what each of them does?

[schneidermic0]

However, the next check in the list is called "Validate JSON"

I had this also in mind, but I think we can differentiate both.

@larshp "Executive" Decision: (as requested by you ;))
Let's keep it short and simple and start with "Validate JSON schema". We can still change it in the future if it is confusing.

[larshp]

updated

[schneidermic0]

Thanks, looks good to me. 👍