-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run more unit tests via transpiler #153
Conversation
larshp
commented
Jul 21, 2022
•
edited
Loading
edited
- removes one unit test case regarding enums. Enums are not in scope, and note the code still works with enums, ref Delete enum related logic #65
this runs a bunch more unit tests via transpiler, ready for review/merge one ABAP related change, see comment above |
If we want to get rid of enum support, because AFF types shall be compatible with release 7.02, then I suggest to remove also (at least) the tested production code;
|
^can we defer that to #65 ? its kind of a pity removing something if it works. The AFF might not be the only future use-case for this tool, so 🤷♂️ |
I am happy if we keep the functionality, but then it would be good that it is also tested, isn't it? I understand you removed it because the transpiler hasn't supported it yet, right? If so, wouldn't it make sense to move this single assert in a specific test method and set the test to ignore? Then we can at least run it in an ABAP system. |
yea, good idea |
@schneidermic0 added in above commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a minor question.
Co-authored-by: Michael Schneider <[email protected]>