run more unit tests via transpiler

[larshp]

• removes one unit test case regarding enums. Enums are not in scope, and note the code still works with enums, ref Delete enum related logic #65

cl_abap_unit_assert=>assert_equals( exp = zif_aff_writer=>type_info-string act = cut->get_json_type_from_description( get_element_description( VALUE zif_aff_writer=>enum_type_info( ) ) ) ).

[larshp]

this runs a bunch more unit tests via transpiler, ready for review/merge

one ABAP related change, see comment above

[schneidermic0]

If we want to get rid of enum support, because AFF types shall be compatible with release 7.02, then I suggest to remove also (at least) the tested production code; OR cl_abap_typedescr=>typekind_enum:

abap-file-formats-tools/src/zcl_aff_writer.clas.abap

Line 309 in 4490c25

cl_abap_typedescr=>typekind_hex OR cl_abap_typedescr=>typekind_num OR cl_abap_typedescr=>typekind_enum.

[larshp]

^can we defer that to #65 ?

its kind of a pity removing something if it works. The AFF might not be the only future use-case for this tool, so 🤷‍♂️

[schneidermic0]

I am happy if we keep the functionality, but then it would be good that it is also tested, isn't it?

I understand you removed it because the transpiler hasn't supported it yet, right? If so, wouldn't it make sense to move this single assert in a specific test method and set the test to ignore? Then we can at least run it in an ABAP system.

[larshp]

I am happy if we keep the functionality, but then it would be good that it is also tested, isn't it?

I understand you removed it because the transpiler hasn't supported it yet, right? If so, wouldn't it make sense to move this single assert in a specific test method and set the test to ignore? Then we can at least run it in an ABAP system.

yea, good idea

[larshp]

@schneidermic0 added in above commit

[schneidermic0]

Looks good to me. Just a minor question.