Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfixes for version 1.19.1 #358

Merged
merged 2 commits into from
Sep 18, 2024
Merged

bugfixes for version 1.19.1 #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de23786
version 1.19.1
jmgrassau Sep 18, 2024
b18820b
set next development version to 1.19.2-SNAPSHOT
jmgrassau Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner.app/abapcleaner.product
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<?pde version="3.5"?>

<product name="ABAP cleaner" uid="com.sap.adt.abapcleaner.app" application="com.sap.adt.abapcleaner.standalone.app" version="1.19.1.qualifier" type="features" includeLaunchers="true" autoIncludeRequirements="true">
<product name="ABAP cleaner" uid="com.sap.adt.abapcleaner.app" application="com.sap.adt.abapcleaner.standalone.app" version="1.19.2.qualifier" type="features" includeLaunchers="true" autoIncludeRequirements="true">

<configIni use="default">
</configIni>
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner.app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>com.sap.adt.abapcleaner.app</artifactId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner.app</name>
<packaging>eclipse-repository</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner.feature/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="com.sap.adt.abapcleaner.feature"
label="ABAP cleaner"
version="1.19.1.qualifier">
version="1.19.2.qualifier">

<description>
ABAP cleaner plug-in for ABAP Development Tools
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner.feature/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<artifactId>com.sap.adt.abapcleaner.feature</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner.feature</name>
<packaging>eclipse-feature</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner.gui/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-SymbolicName: com.sap.adt.abapcleaner.gui;singleton:=true
Bundle-Version: 1.19.1.qualifier
Bundle-Version: 1.19.2.qualifier
Bundle-Vendor: %Provider-Name
Bundle-Localization: plugin
Bundle-RequiredExecutionEnvironment: JavaSE-17
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner.gui/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>com.sap.adt.abapcleaner.gui</artifactId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner.gui</name>
<packaging>eclipse-plugin</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner.updatesite/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0">
<modelVersion>4.0.0</modelVersion>
<artifactId>com.sap.adt.abapcleaner.updatesite</artifactId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<name>ABAP Cleaner for ABAP Development Tools (ADT)</name>
<packaging>eclipse-repository</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-SymbolicName: com.sap.adt.abapcleaner;singleton:=true
Bundle-Version: 1.19.1.qualifier
Bundle-Version: 1.19.2.qualifier
Bundle-Vendor: %Provider-Name
Bundle-Localization: plugin
Bundle-RequiredExecutionEnvironment: JavaSE-17
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>com.sap.adt.abapcleaner</artifactId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner</name>
<packaging>eclipse-plugin</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions docs/release-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ as well as bugfixes of reported issues, i.e. anything that enhances or changes t
For a complete list of changes (including documentation, tests, refactoring etc.), please refer to
the list of [commits](../../../commits/main).

## 2024-09-18 (version 1.19.0)
## 2024-09-18 (version 1.19.1)

**Thanks a lot**, [**MDagni**](https://github.com/MDagni) for opening the issue that led to the bugfix!

* **Enhanced** parser, object model and UI **for Data Definition Language (DDL)**
* **Enhanced** parser, object model and UI **for Data Definition Language (DDL)** as used in **CDS Views**
* Added new DDL rule '**Standardize annotation layout**'
* Added new DDL rule '**Rearrange annotations**'
* Added new DDL rule '**Break before DEFINE etc.**'
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>parent</artifactId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<name>ABAP cleaner</name>
<packaging>pom</packaging>
<modules>
Expand Down
2 changes: 1 addition & 1 deletion test/com.sap.adt.abapcleaner.test/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: Unit Tests for com.sap.adt.abapcleaner
Bundle-SymbolicName: com.sap.adt.abapcleaner.test;singleton:=true
Bundle-Version: 1.19.1.qualifier
Bundle-Version: 1.19.2.qualifier
Bundle-Vendor: abap-dev
Fragment-Host: com.sap.adt.abapcleaner
Bundle-RequiredExecutionEnvironment: JavaSE-17
Expand Down
4 changes: 2 additions & 2 deletions test/com.sap.adt.abapcleaner.test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>com.sap.adt.abapcleaner.test</artifactId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner.test</name>
<packaging>eclipse-test-plugin</packaging>

<parent>
<artifactId>tests</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion ...p.adt.abapcleaner.test/src/com/sap/adt/abapcleaner/rulehelpers/CommentIdentifierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ void testDdlText() {

@Test
void testIdentifyDdlWithOutput() {
String LINE_SEP = System.lineSeparator();
String LINE_SEP = ABAP.LINE_SEPARATOR; // must NOT be System.lineSeparator(), since CommentIdentifier.identifyComments() uses ABAP.LINE_SEPARATOR
String code = "// line-start comment"
+ LINE_SEP + " //"
+ LINE_SEP + " // non-line-start comment A"
Expand Down
4 changes: 2 additions & 2 deletions test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>tests</artifactId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<name>Test Fragments</name>
<packaging>pom</packaging>

<parent>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>parent</artifactId>
<version>1.19.1-SNAPSHOT</version>
<version>1.19.2-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
Loading