Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancements and bugfixes for version 1.16.2 #311

Merged
merged 6 commits into from
Jun 3, 2024
Merged

enhancements and bugfixes for version 1.16.2 #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26bf585
fix display of mnemonic character & on SWT Labels
jmgrassau May 29, 2024
0c9845b
fix StringTemplateRule for concatenation operators at line end (#306)
jmgrassau May 29, 2024
f95b1ce
fix IndentRule for PrettyPrinter indentation of INCLUDE (#278)
jmgrassau May 30, 2024
db93fd4
update known CamelCase names
jmgrassau Jun 3, 2024
aa18515
version 1.16.2
jmgrassau Jun 3, 2024
62454da
set next development version to 1.16.3-SNAPSHOT
jmgrassau Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner.app/abapcleaner.product
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<?pde version="3.5"?>

<product name="ABAP cleaner" uid="com.sap.adt.abapcleaner.app" application="com.sap.adt.abapcleaner.standalone.app" version="1.16.2.qualifier" useFeatures="true" includeLaunchers="true">
<product name="ABAP cleaner" uid="com.sap.adt.abapcleaner.app" application="com.sap.adt.abapcleaner.standalone.app" version="1.16.3.qualifier" useFeatures="true" includeLaunchers="true">

<configIni use="default">
</configIni>
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner.app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>com.sap.adt.abapcleaner.app</artifactId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner.app</name>
<packaging>eclipse-repository</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner.feature/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="com.sap.adt.abapcleaner.feature"
label="ABAP cleaner"
version="1.16.2.qualifier">
version="1.16.3.qualifier">

<description>
ABAP cleaner plug-in for ABAP Development Tools
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner.feature/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<artifactId>com.sap.adt.abapcleaner.feature</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner.feature</name>
<packaging>eclipse-feature</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner.gui/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-SymbolicName: com.sap.adt.abapcleaner.gui;singleton:=true
Bundle-Version: 1.16.2.qualifier
Bundle-Version: 1.16.3.qualifier
Bundle-Vendor: %Provider-Name
Bundle-Localization: plugin
Bundle-RequiredExecutionEnvironment: JavaSE-11
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner.gui/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>com.sap.adt.abapcleaner.gui</artifactId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner.gui</name>
<packaging>eclipse-plugin</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner.gui/src/com/sap/adt/abapcleaner/gui/FrmMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,7 +1930,7 @@ public final void searchModeChanged(boolean searchMode) {
}

public final void searchTextChanged(String text, boolean found) {
lblSearch.setText(text);
lblSearch.setText(StringUtil.getLabelText(text));
lblSearch.setForeground(found ? searchTextNormalColor : searchTextNotFoundColor);
}

Expand Down
15 changes: 8 additions & 7 deletions com.sap.adt.abapcleaner.gui/src/com/sap/adt/abapcleaner/gui/FrmProfiles.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ public void widgetSelected(SelectionEvent e) {
lblRuleDescription = new Label(pnlRuleDescription, SWT.NONE);
lblRuleDescription.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false, 1, 1));
lblRuleDescription.setText(".");

lblRuleHintsAndRestrictions = new Label(pnlRuleDescription, SWT.NONE);
lblRuleHintsAndRestrictions.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false, 1, 1));
lblRuleHintsAndRestrictions.setText(".");
Expand Down Expand Up @@ -1174,13 +1174,13 @@ private void setRule(Rule rule) {

disposeConfigControls();

lblRuleName.setText((rule != null && rule.getDisplayName() != null) ? rule.getDisplayName() : "");
lblRuleName.setText((rule != null) ? StringUtil.getLabelText(rule.getDisplayName()) : "");
if (highlighter != null) {
highlighter.setRuleNameHighlight(rule);
}

lblRuleDescription.setText((rule != null && rule.getDescription() != null) ? rule.getDescription() : "");
lblRuleHintsAndRestrictions.setText((rule != null && rule.getHintsAndRestrictions() != null) ? rule.getHintsAndRestrictions() : "");
lblRuleDescription.setText((rule != null) ? StringUtil.getLabelText(rule.getDescription()) : "");
lblRuleHintsAndRestrictions.setText((rule != null) ? StringUtil.getLabelText(rule.getHintsAndRestrictions()) : "");

// show references
pnlRuleReferences.setRedraw(false);
Expand All @@ -1191,10 +1191,11 @@ private void setRule(Rule rule) {
String source = "";
if (reference != null && !StringUtil.isNullOrEmpty(reference.getSourceText())) {
source = reference.getSourceText();
if (!StringUtil.isNullOrEmpty(reference.chapterTitle))
if (!StringUtil.isNullOrEmpty(reference.chapterTitle)) {
source += ":";
}
}
lblRuleSources[i].setText(source);
lblRuleSources[i].setText(StringUtil.getLabelText(source));
Rectangle bounds = lblRuleSources[i].getBounds();
maxRight = Math.max(maxRight, bounds.x + bounds.width);
}
Expand All @@ -1203,7 +1204,7 @@ private void setRule(Rule rule) {
RuleReference reference = (references == null || i >= references.length) ? null : references[i];
lblRuleSources[i].setVisible((reference != null));

lblRuleChapters[i].setText((reference != null && reference.chapterTitle != null) ? reference.chapterTitle : "");
lblRuleChapters[i].setText((reference != null) ? StringUtil.getLabelText(reference.chapterTitle) : "");
ruleChapterLink[i] = (reference != null ? reference.getLink() : null);
lblRuleChapters[i].setLocation(chapterLeft, lblRuleChapters[i].getLocation().y);
if (reference != null && highlighter != null) {
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner.updatesite/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0">
<modelVersion>4.0.0</modelVersion>
<artifactId>com.sap.adt.abapcleaner.updatesite</artifactId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<name>ABAP Cleaner for ABAP Development Tools (ADT)</name>
<packaging>eclipse-repository</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion com.sap.adt.abapcleaner/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-SymbolicName: com.sap.adt.abapcleaner;singleton:=true
Bundle-Version: 1.16.2.qualifier
Bundle-Version: 1.16.3.qualifier
Bundle-Vendor: %Provider-Name
Bundle-Localization: plugin
Bundle-RequiredExecutionEnvironment: JavaSE-11
Expand Down
4 changes: 2 additions & 2 deletions com.sap.adt.abapcleaner/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<modelVersion>4.0.0</modelVersion>
<groupId>com.sap.adt.abapcleaner</groupId>
<artifactId>com.sap.adt.abapcleaner</artifactId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<name>com.sap.adt.abapcleaner</name>
<packaging>eclipse-plugin</packaging>

<parent>
<artifactId>parent</artifactId>
<groupId>com.sap.adt.abapcleaner</groupId>
<version>1.16.2-SNAPSHOT</version>
<version>1.16.3-SNAPSHOT</version>
<relativePath>../</relativePath>
</parent>

Expand Down
Loading
Loading