Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create minimal R package #14

Merged
merged 22 commits into from
Sep 2, 2024
Merged

Create minimal R package #14

merged 22 commits into from
Sep 2, 2024

Conversation

stefpiatek
Copy link
Contributor

@stefpiatek stefpiatek commented Aug 28, 2024

Tried to keep it minimal but quickly got out of hand it seems. Shamelessly copied readme from data catalogue but let me know what you think.

Expect may need to document it some more but at a point where I think its worth taking feedback.

Closes #1
Closes #8
Closes #5

@stefpiatek stefpiatek requested review from a team and anabarbararc August 29, 2024 08:37
Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉 Thanks Stef!
Just a few small suggestions

DESCRIPTION Show resolved Hide resolved
R/bundles.R Outdated Show resolved Hide resolved
R/bundles.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@anabarbararc anabarbararc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Stef,

It looks like really good progress! Sorry for taking long. I don't have any suggestions so far.

@stefpiatek stefpiatek merged commit 9892d69 into main Sep 2, 2024
2 checks passed
@stefpiatek stefpiatek deleted the stef/boilerplate branch September 2, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants