x509-cert: make Name a new type over RdnSequence
#1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/x509-cert/name-newtype
branch
5 times, most recently
from
3a8da71
to
d059733
Compare
tarcieri
reviewed
Sep 5, 2024
tarcieri
approved these changes
Sep 5, 2024
str4d
suggested changes
Sep 5, 2024
baloo
force-pushed
the
baloo/x509-cert/name-newtype
branch
2 times, most recently
from
b168e0d
to
d9fbfc4
Compare
baloo
force-pushed
the
baloo/x509-cert/name-newtype
branch
3 times, most recently
from
94ddacf
to
32615dd
Compare
|
I guess there would be value in a builder for name, but this PR is already large enough. |
baloo
force-pushed
the
baloo/x509-cert/name-newtype
branch
2 times, most recently
from
cd16b39
to
cb27b48
Compare
|
@baloo some merge conflicts in the tests. Edit: oof, a lot more now, sorry. I'm done for now. |
This make `FromStr` documented way to build a name. This also exposes a set of getter methods to get elements from the name (CN, Org, ...).
baloo
force-pushed
the
baloo/x509-cert/name-newtype
branch
from
cb27b48
to
593176c
Compare
|
Going to merge this both as an improvement and to avoid additional merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make
FromStrdocumented way to build a name. This also exposes a set of getter methods to get elements from the name (CN, Org, ...).see:
Name#1489Name#1493