der: refactor Reader::read_nested
#1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tarcieri
force-pushed
the
der/refactor-nested-reader
branch
3 times, most recently
from
7c85617
to
85034e1
Compare
Gets rid of a provided method along with the `NestedReader` type, in order to fix #1228. Instead, each reader must now implement its own strategy for nested reading.
tarcieri
force-pushed
the
der/refactor-nested-reader
branch
from
85034e1
to
e27c484
Compare
tarcieri
changed the title
Reader::read_nestedReader::read_nested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of a provided method along with the
NestedReadertype, in order to fix #1228.Instead, each reader must now implement its own strategy for nested reading.