Skip to content

Commit

Permalink
Merge remote-tracking branch 'rustcrypto/master' into cms/pwri-builder
Browse files Browse the repository at this point in the history
  • Loading branch information
kletterstein committed Oct 16, 2024
2 parents 48e0a4e + 8a854c7 commit e374257
Show file tree
Hide file tree
Showing 9 changed files with 21 additions and 22 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pem-rfc7468.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
strategy:
matrix:
rust:
- 1.65.0 # MSRV
- 1.81.0 # MSRV
- stable
target:
- thumbv7em-none-eabi
Expand All @@ -41,14 +41,14 @@ jobs:
minimal-versions:
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
strategy:
matrix:
rust:
- 1.65.0 # MSRV
- 1.81.0 # MSRV
- stable
steps:
- uses: actions/checkout@v4
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/security-audit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ jobs:
- uses: dtolnay/rust-toolchain@master
with:
toolchain: stable
- uses: actions/cache@v4
with:
path: ~/.cargo/bin
key: ${{ runner.os }}-cargo-audit-v0.20
# TODO(tarcieri): investigate why cached binaries aren't working
#- uses: actions/cache@v4
# with:
# path: ~/.cargo/bin
# key: ${{ runner.os }}-cargo-audit-v0.20
- uses: rustsec/audit-check@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions cms/src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ impl<'s> SignedDataBuilder<'s> {
S: Keypair + DynSignatureAlgorithmIdentifier,
S: AsyncSigner<Signature>,
S::VerifyingKey: EncodePublicKey,
Signature: SignatureBitStringEncoding + 'static,
Signature: SignatureBitStringEncoding,
{
let signer_info = signer_info_builder
.build_async::<S, Signature>(signer)
Expand All @@ -461,7 +461,7 @@ impl<'s> SignedDataBuilder<'s> {
S: Keypair + DynSignatureAlgorithmIdentifier,
S: AsyncRandomizedSigner<Signature>,
S::VerifyingKey: EncodePublicKey,
Signature: SignatureBitStringEncoding + 'static,
Signature: SignatureBitStringEncoding,
{
let signer_info = signer_info_builder
.build_with_rng_async::<S, Signature>(signer, rng)
Expand Down
4 changes: 2 additions & 2 deletions pem-rfc7468/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pem-rfc7468"
version = "1.0.0-rc.1"
version = "1.0.0-rc.2"
description = """
PEM Encoding (RFC 7468) for PKIX, PKCS, and CMS Structures, implementing a
strict subset of the original Privacy-Enhanced Mail encoding intended
Expand All @@ -16,7 +16,7 @@ categories = ["cryptography", "data-structures", "encoding", "no-std", "parser-i
keywords = ["crypto", "key", "pem", "pkcs", "rsa"]
readme = "README.md"
edition = "2021"
rust-version = "1.60"
rust-version = "1.81"

[dependencies]
base64ct = { version = "1.4" }
Expand Down
4 changes: 2 additions & 2 deletions pem-rfc7468/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ to practically extract RSA private keys from SGX enclaves.

## Minimum Supported Rust Version

This crate requires **Rust 1.60** at a minimum.
This crate requires **Rust 1.81** at a minimum.

We may change the MSRV in the future, but it will be accompanied by a minor
version bump.
Expand Down Expand Up @@ -87,7 +87,7 @@ dual licensed as above, without any additional terms or conditions.
[build-image]: https://github.com/RustCrypto/formats/actions/workflows/pem-rfc7468.yml/badge.svg
[build-link]: https://github.com/RustCrypto/formats/actions/workflows/pem-rfc7468.yml
[license-image]: https://img.shields.io/badge/license-Apache2.0/MIT-blue.svg
[rustc-image]: https://img.shields.io/badge/rustc-1.60+-blue.svg
[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
[chat-image]: https://img.shields.io/badge/zulip-join_chat-blue.svg
[chat-link]: https://rustcrypto.zulipchat.com/#narrow/stream/300570-formats

Expand Down
3 changes: 1 addition & 2 deletions pem-rfc7468/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ impl fmt::Display for Error {
}
}

#[cfg(feature = "std")]
impl std::error::Error for Error {}
impl core::error::Error for Error {}

impl From<base64ct::Error> for Error {
fn from(err: base64ct::Error) -> Error {
Expand Down
2 changes: 1 addition & 1 deletion sec1/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "sec1"
version = "0.8.0-rc.2"
version = "0.8.0-rc.3"
description = """
Pure Rust implementation of SEC1: Elliptic Curve Cryptography encoding formats
including ASN.1 DER-serialized private keys as well as the
Expand Down
5 changes: 2 additions & 3 deletions sec1/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ pub enum Error {
Version,
}

impl core::error::Error for Error {}

impl fmt::Display for Error {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Expand Down Expand Up @@ -77,6 +79,3 @@ impl From<pkcs8::spki::Error> for Error {
Error::Pkcs8(pkcs8::Error::PublicKey(err))
}
}

#[cfg(feature = "std")]
impl std::error::Error for Error {}

0 comments on commit e374257

Please sign in to comment.