Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srp: compute K = H(S) correctly. #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commits on Apr 8, 2024

  1. srp: compute K = H(S) correctly.

    According to [the specification] section _The SRP protocol_, `K` (which corresponds
    to the session key) is computed as follows:
    
    ```
    K = H(S)
    ```
    
    where `H` is the digest algorithm, and `S` is the common exponential value.
    
    In the [current implementation], `K` is equal to `S`, which does not follow
    the SRP protocol specification.
    
    This commit fixes this issue by computing the right value for `K`.
    
    [the specification]: http://srp.stanford.edu/ndss.html#SECTION00032200000000000000
    [current implementation]: https://github.com/RustCrypto/PAKEs/blob/8e46d6bfa24d44e6671616d730e978157b2b23e3/srp/src/client.rs#L211
    zadlg committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6773e36 View commit details
    Browse the repository at this point in the history