-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional Logging level functions to the logging module #1441
base: master
Are you sure you want to change the base?
Conversation
Thanks, I will have a look once you fix my comment. Also don't forget to run |
cargo fmt the code
The closure thing is very messy, just use |
function which accepts priority enum as parameter
Now i have replaced all those function wrappers with the closures in them with just one single pub function which accepts the priority enum and matches it to invoke the unsafe sdl log functions |
Much better. I think you can still add |
which call the generic logging function
Ok did that now! |
This PR will add Log prioriyt dependent logging functions:
where * is: create, warning, error etc.
In addition to the message those new functions will take the Category as paraemter,
the Category needs to be converted to c_int, if that fails, Application value is taken and assumed it will be convertible to c_int.