Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static linking #1397

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix static linking #1397

merged 1 commit into from
Jun 13, 2024

Conversation

sandydoo
Copy link
Contributor

@sandydoo sandydoo commented May 5, 2024

Re-enables static linking when static-link is enabled on its own, without any other packaging features, like use-pkgconfig. This fixes a regression introduced in #1352.

@Cobrand
Copy link
Member

Cobrand commented May 6, 2024

Thanks! Before merging this I need to fix the pipeline, it might take a while before it's merged.

@sandydoo
Copy link
Contributor Author

sandydoo commented May 6, 2024

A quick way to fix CI is to switch to macos-13, which still uses x86 runners. The new macos-latest is ARM-only.

I'll try to debug the ARM macOS issue.

@sandydoo
Copy link
Contributor Author

sandydoo commented May 6, 2024

I think the issue is that the video test is not running on the main thread. --test-threads=1 still breaks, but running cargo test --features "..." video works.
We might have to run the tests manually then, without the harness. At least on macOS.

@Cobrand Cobrand merged commit 22a8c31 into Rust-SDL2:master Jun 13, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants