Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the db file to disappear immediately after creation #154

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

timj
Copy link
Collaborator

@timj timj commented Jul 26, 2024

No description provided.

@timj
Copy link
Collaborator Author

timj commented Jul 26, 2024

@ktlim this might be what you need.

@timj
Copy link
Collaborator Author

timj commented Jul 26, 2024

The other odd thing is that AtomicFile is doing os.rename on the file name directly before that call to stat. It's saying that somehow

os.rename(tmpfn, fn)
os.stat(fn)

is a reproducible race in your test code.

This was added in python 3.4. We could use protocol 5 but we are
still testing python 3.7.
@timj timj merged commit da26a50 into master Jul 29, 2024
8 checks passed
@timj timj deleted the u/timj/db-race branch July 29, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants