Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency nikic/php-parser to v5 - autoclosed #1387

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 8, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nikic/php-parser ^4.18.0 -> ^5.0.2 age adoption passing confidence

Release Notes

nikic/PHP-Parser (nikic/php-parser)

v5.0.2

Compare Source

Fixed
  • Fix handling of indentation on next line after opening PHP tag in formatting-preserving pretty
    printer.
Changed
  • Avoid cyclic references in Parser objects. This means that no longer used parser objects are
    immediately destroyed now, instead of requiring cycle GC.
  • Update PhpVersion::getNewestSupported() to report PHP 8.3 instead of PHP 8.2.

v5.0.1

Compare Source

Changed
  • Added check to detect use of PHP-Parser with libraries that define T_* compatibility tokens
    with incorrect type (such as string instead of int). This would lead to TypeErrors down the
    line. Now an Error will be thrown early to indicate the problem.

v5.0.0

Compare Source

See UPGRADE-5.0 for detailed migration instructions.

Fixed
  • Fixed parent class of PropertyItem and UseItem.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Read more about the use of Renovate Bot within ocramius/* projects.

@renovate renovate bot added the renovate label Jan 8, 2024
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 6 times, most recently from 433cf0e to e40037e Compare January 15, 2024 12:27
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch from e40037e to b334009 Compare January 15, 2024 16:39
@renovate renovate bot changed the base branch from 6.22.x to 6.23.x January 15, 2024 16:39
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 3 times, most recently from 0b01c6b to b3d0f80 Compare January 19, 2024 10:33
@Ocramius
Copy link
Member

If we want to move this forward from our end, it's probably feasible via extracting test dependencies to their own directory.

That becomes a pain with the test setup though, so unsure about the chicken-egg situation, for now.

Will sleep over it a few times 🤔

@renovate renovate bot changed the base branch from 6.23.x to 6.24.x January 19, 2024 12:40
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 3 times, most recently from c90fc01 to 91b72da Compare January 24, 2024 17:31
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 6 times, most recently from 3b7e868 to 7f43414 Compare February 1, 2024 07:18
@tacman
Copy link
Contributor

tacman commented Feb 2, 2024

It's not a big deal, but it'd be nice if you could support version 5.

composer why nikic/php-parser 
phpunit/php-code-coverage 9.2.30  requires nikic/php-parser (^4.18 || ^5.0) 
roave/better-reflection   6.23.0  requires nikic/php-parser (^4.18.0)       
sebastian/complexity      2.0.3   requires nikic/php-parser (^4.18 || ^5.0) 
sebastian/lines-of-code   1.0.4   requires nikic/php-parser (^4.18 || ^5.0) 
symfony/maker-bundle      v1.53.0 requires nikic/php-parser (^4.18|^5.0)    

@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 3 times, most recently from 4783453 to 80c5b51 Compare February 8, 2024 03:43
@tacman
Copy link
Contributor

tacman commented Feb 8, 2024

While I don't understand rennovate, it's working in 'dev' for me now, thanks!

composer why nikic/php-parser 
phpunit/php-code-coverage 9.2.30                            requires nikic/php-parser (^4.18 || ^5.0) 
roave/better-reflection   dev-renovate/nikic-php-parser-5.x requires nikic/php-parser (^5.0.0)        
sebastian/complexity      2.0.3                             requires nikic/php-parser (^4.18 || ^5.0) 
sebastian/lines-of-code   1.0.4                             requires nikic/php-parser (^4.18 || ^5.0) 
symfony/maker-bundle      v1.54.0                           requires nikic/php-parser (^4.18|^5.0)    

@Ocramius
Copy link
Member

Ocramius commented Feb 8, 2024

In theory, this is fixable via Roave/infection-static-analysis-plugin#489 (and some additional testing), but I'm stuck over there due to tests failing for a missing coverage driver.

What is confusing me is why the mainline branch and the PR have different build environments (within the same day): Roave/infection-static-analysis-plugin#489 (comment)

@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch from 80c5b51 to f8ab759 Compare February 9, 2024 04:00
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 4 times, most recently from 41b0f37 to eee58f4 Compare February 28, 2024 03:10
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 5 times, most recently from 90c6f4f to 5f015f3 Compare March 8, 2024 15:45
@renovate renovate bot changed the base branch from 6.24.x to 6.25.x March 8, 2024 15:56
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 6 times, most recently from a7eca26 to 5fa25fb Compare March 10, 2024 12:25
@renovate renovate bot changed the base branch from 6.25.x to 6.26.x March 10, 2024 12:25
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch from 5fa25fb to d2c632b Compare March 10, 2024 17:42
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch 2 times, most recently from 8d02034 to 6bed0e7 Compare March 11, 2024 17:43
@renovate renovate bot changed the base branch from 6.26.x to 6.27.x March 11, 2024 17:44
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch from 6bed0e7 to 5603f73 Compare March 11, 2024 19:15
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch from 5603f73 to 881a1f5 Compare March 12, 2024 01:34
| datasource | package          | from   | to    |
| ---------- | ---------------- | ------ | ----- |
| packagist  | nikic/php-parser | 4.18.0 | 5.0.2 |
@renovate renovate bot force-pushed the renovate/nikic-php-parser-5.x branch from 881a1f5 to 29ab04c Compare March 12, 2024 03:05
@renovate renovate bot changed the title Update dependency nikic/php-parser to v5 Update dependency nikic/php-parser to v5 - autoclosed Mar 12, 2024
@renovate renovate bot closed this Mar 12, 2024
@renovate renovate bot deleted the renovate/nikic-php-parser-5.x branch March 12, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants