Don't ignore MissingImmutableAnnotation in Psalm globally

Roave · Nov 13, 2021 · 9fde8ea · 9fde8ea
1 parent b4832be
commit 9fde8ea
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/psalm.xml b/psalm.xml
@@ -15,8 +15,6 @@
     </projectFiles>
 
     <issueHandlers>
-        <MissingImmutableAnnotation errorLevel="suppress" />
-
         <NullableReturnStatement errorLevel="suppress" />
         <InvalidNullableReturnType errorLevel="suppress" />
 

diff --git a/src/Reflection/Adapter/ReflectionNamedType.php b/src/Reflection/Adapter/ReflectionNamedType.php
@@ -7,6 +7,9 @@
 use ReflectionNamedType as CoreReflectionNamedType;
 use Roave\BetterReflection\Reflection\ReflectionNamedType as BetterReflectionNamedType;
 
+/**
+ * @psalm-suppress MissingImmutableAnnotation
+ */
 final class ReflectionNamedType extends CoreReflectionNamedType
 {
     public function __construct(private BetterReflectionNamedType $betterReflectionType)

diff --git a/src/Reflection/Adapter/ReflectionParameter.php b/src/Reflection/Adapter/ReflectionParameter.php
@@ -14,6 +14,9 @@
 
 use function array_map;
 
+/**
+ * @psalm-suppress MissingImmutableAnnotation
+ */
 final class ReflectionParameter extends CoreReflectionParameter
 {
     public function __construct(private BetterReflectionParameter $betterReflectionParameter)

diff --git a/src/Reflection/Adapter/ReflectionProperty.php b/src/Reflection/Adapter/ReflectionProperty.php
@@ -75,8 +75,12 @@ public function hasType(): bool
         return $this->betterReflectionProperty->hasType();
     }
 
+    /**
+     * @psalm-mutation-free
+     */
     public function getType(): ReflectionUnionType|ReflectionNamedType|ReflectionIntersectionType|null
     {
+        /** @psalm-suppress ImpureMethodCall */
         return ReflectionType::fromTypeOrNull($this->betterReflectionProperty->getType());
     }