Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker labels for ghcr.io #20

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add Docker labels for ghcr.io #20

merged 1 commit into from
Jul 19, 2023

Conversation

applejag
Copy link
Member

Finally figured out why the pushed images didn't appear on the GitHub page. You have to link them with a Docker label.

@applejag applejag requested a review from a team as a code owner July 19, 2023 12:06
@applejag applejag requested review from jadolg and nicmr and removed request for a team July 19, 2023 12:06
@applejag applejag added the enhancement New feature or request label Jul 19, 2023
@applejag applejag self-assigned this Jul 19, 2023
@jadolg
Copy link
Member

jadolg commented Jul 19, 2023

Do you mean here?
image

Nevermind, I just noticed Earthfile

@applejag
Copy link
Member Author

Yes, I meant there. I pushed the image before and it didn't appear. It was first when I added these labels that you see in the PR changes that the package appeared there

@jadolg
Copy link
Member

jadolg commented Jul 19, 2023

I'm building images using docker buildkit on GitHub and pushing there and so far they have appeared just fine.
Maybe Earthly does it different 🤷‍♂️

@applejag
Copy link
Member Author

applejag commented Jul 19, 2023

@jadolg Our decision to go with Earthly predates our use of GitHub Actions (this repo wasn't always on github.com). We wanted to find something that was easier to use than Jenkins.

Earthly is basically just the combination of a Dockerfile and a Makefile. It was very easy to define our Earthfiles to both build the image, tag it correctly, and push it to our registry.

Nowadays that we have GH Actions we might want to just get rid of it, as I do like having just a Dockerfile available. Now you HAVE to use Earthly, which is less nice.

@applejag applejag merged commit d227d49 into main Jul 19, 2023
3 checks passed
@applejag applejag deleted the feature/add-docker-labels branch July 19, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants