[OP-1796] Deferred PR creation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applejag
requested review from
jadolg,
zoro16 and
nicmr
and removed request for
a team
jadolg
reviewed
Jul 14, 2023
|
This PR is way too big 😵 |
Yep, sorry about this. This PR is the definition of scope creep. I could try split it up if that helps? |
|
If possible without unreasonable effort that'd be awesome! |
Me and Jorge talked, and went for trying a pair-review meeting instead. There's so much scattered in this PR, that extracting to multiple PRs will get tedious. I've invited you too to that meeting ofc |
applejag
commented
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: OP-1796
A lot of changes in this one. To summarize in one word: HTML!
In big brush strokes, the changes are:
Added HTML templating, using github.com/gin-contrib/multitemplate, so we can have reusable "layout page"
Added favicon and auxiliary files, generated from docs/jelease-gopher-profile-orig.jpg using https://realfavicongenerator.net/
Refactored a bunch here and there to make these features not complete spaghetti
Added Gin logger shim, to have prettier logs from Gin-Gonic, as well as correct logging severity
Added some new configs:
http.publicUrljira.issue.comments.prDeferredCreationjira.issue.prDeferredCreationPreview
Open question
jira.issue.prDeferredCreationcorrectly placed? It's not directly tied to Jira issues, but I didn't know where else to put it. Maybe just as a root config?